From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:44853)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1VBn4G-0004xa-IS
	for qemu-devel@nongnu.org; Tue, 20 Aug 2013 10:38:02 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1VBn49-0000Za-Lw
	for qemu-devel@nongnu.org; Tue, 20 Aug 2013 10:37:56 -0400
Received: from mail-we0-x22e.google.com ([2a00:1450:400c:c03::22e]:50103)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1VBn49-0000ZK-FO
	for qemu-devel@nongnu.org; Tue, 20 Aug 2013 10:37:49 -0400
Received: by mail-we0-f174.google.com with SMTP id q54so477118wes.5
	for <qemu-devel@nongnu.org>; Tue, 20 Aug 2013 07:37:48 -0700 (PDT)
Date: Tue, 20 Aug 2013 16:37:45 +0200
From: Stefan Hajnoczi <stefanha@gmail.com>
Message-ID: <20130820143745.GB5536@stefanha-thinkpad.redhat.com>
References: <1609927484.62705.1376639964118.open-xchange@email.1und1.de>
	<CAFEAcA8oFc6r8h4ibfCJNWwa==gzA+DA-h4qAw+mk3HFvMoGwA@mail.gmail.com>
	<521222B5.2050202@suse.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <521222B5.2050202@suse.de>
Subject: Re: [Qemu-devel] [Bug?] qemu-1.6.0 python traceback in GEN
 qmp-commands.h
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Andreas =?iso-8859-1?Q?F=E4rber?= <afaerber@suse.de>
Cc: Peter Maydell <peter.maydell@linaro.org>, "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>, Erik Rull <erik.rull@rdsoftware.de>

On Mon, Aug 19, 2013 at 03:50:45PM +0200, Andreas Färber wrote:
> Am 16.08.2013 15:21, schrieb Peter Maydell:
> > On 16 August 2013 08:59, Erik Rull <erik.rull@rdsoftware.de> wrote:
> >> Hi all,
> >>
> >> when using the released qemu-1.6.0.tar.bz2, I get the following error message:
> >>   File "/home/erik/qemu-1.6.0/scripts/qapi.py", line 164
> >>     except QAPISchemaError as e:
> >>                             ^
> >> SyntaxError: invalid syntax
> >> make: *** [qmp-commands.h] Error 1
> > 
> > My guess is that your python is older than 2.6; I think
> > the "except Foo as e" syntax is new in 2.6. We probably
> > missed this because most people use a newer Python than
> > 2.6, but configure's check only requires 2.4 or better.
> > 
> > We should probably update the scripts to not use overly
> > new features (or alternatively decide that 2.6 is our new
> > minimum -- what do RHEL5 and our other oldest-supported
> > distros ship?)
> 
> I vaguely remember running into such problems before... possibly on
> Solaris. We compiled a list of Python versions and I think settled for
> 2.4 based on some old RHEL, too. CC'ing Stefan.
> 
> git-blame points to:
> http://repo.or.cz/w/qemu.git/commit/e120d449e1b39ec508c297b963ce452628dd37c3?f=configure

Yes, we should write Python 2.4+ code so that even oldish distros can
execute our scripts.

Stefan