qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
* [Qemu-devel] [PATCH] q35: Add PCIe switch to example q35 configuration
@ 2013-08-20 18:21 Alex Williamson
  2013-08-21  9:31 ` Markus Armbruster
  2013-08-21  9:39 ` Michael S. Tsirkin
  0 siblings, 2 replies; 3+ messages in thread
From: Alex Williamson @ 2013-08-20 18:21 UTC (permalink / raw)
  To: qemu-devel; +Cc: armbru, kraxel, mst

Signed-off-by: Alex Williamson <alex.williamson@redhat.com>
---
 docs/q35-chipset.cfg |   23 +++++++++++++++++++++++
 1 file changed, 23 insertions(+)

diff --git a/docs/q35-chipset.cfg b/docs/q35-chipset.cfg
index 1b6efc0..e4ddb7d 100644
--- a/docs/q35-chipset.cfg
+++ b/docs/q35-chipset.cfg
@@ -91,6 +91,29 @@
   port = "4"
   chassis = "4"
 
+##
+# Example PCIe switch with two downstream ports
+#
+#[device "pcie-switch-upstream-port-1"]
+#  driver = "x3130-upstream"
+#  bus = "ich9-pcie-port-4"
+#  addr = "00.0"
+#
+#[device "pcie-switch-downstream-port-1-1"]
+#  driver = "xio3130-downstream"
+#  multifunction = "on"
+#  bus = "pcie-switch-upstream-port-1"
+#  addr = "00.0"
+#  port = "1"
+#  chassis = "5"
+#
+#[device "pcie-switch-downstream-port-1-2"]
+#  driver = "xio3130-downstream"
+#  multifunction = "on"
+#  bus = "pcie-switch-upstream-port-1"
+#  addr = "00.1"
+#  port = "1"
+#  chassis = "6"
 
 [device "ich9-ehci-1"]
   driver = "ich9-usb-ehci1"

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [Qemu-devel] [PATCH] q35: Add PCIe switch to example q35 configuration
  2013-08-20 18:21 [Qemu-devel] [PATCH] q35: Add PCIe switch to example q35 configuration Alex Williamson
@ 2013-08-21  9:31 ` Markus Armbruster
  2013-08-21  9:39 ` Michael S. Tsirkin
  1 sibling, 0 replies; 3+ messages in thread
From: Markus Armbruster @ 2013-08-21  9:31 UTC (permalink / raw)
  To: Alex Williamson; +Cc: mst, qemu-devel, kraxel

Alex Williamson <alex.williamson@redhat.com> writes:

> Signed-off-by: Alex Williamson <alex.williamson@redhat.com>
> ---
>  docs/q35-chipset.cfg |   23 +++++++++++++++++++++++
>  1 file changed, 23 insertions(+)
>
> diff --git a/docs/q35-chipset.cfg b/docs/q35-chipset.cfg
> index 1b6efc0..e4ddb7d 100644
> --- a/docs/q35-chipset.cfg
> +++ b/docs/q35-chipset.cfg
> @@ -91,6 +91,29 @@
>    port = "4"
>    chassis = "4"
>  
> +##
> +# Example PCIe switch with two downstream ports
> +#
> +#[device "pcie-switch-upstream-port-1"]
> +#  driver = "x3130-upstream"
> +#  bus = "ich9-pcie-port-4"
> +#  addr = "00.0"
> +#
> +#[device "pcie-switch-downstream-port-1-1"]
> +#  driver = "xio3130-downstream"
> +#  multifunction = "on"
> +#  bus = "pcie-switch-upstream-port-1"
> +#  addr = "00.0"
> +#  port = "1"
> +#  chassis = "5"
> +#
> +#[device "pcie-switch-downstream-port-1-2"]
> +#  driver = "xio3130-downstream"
> +#  multifunction = "on"
> +#  bus = "pcie-switch-upstream-port-1"
> +#  addr = "00.1"
> +#  port = "1"
> +#  chassis = "6"
>  
>  [device "ich9-ehci-1"]
>    driver = "ich9-usb-ehci1"

Yes, please!

I decommented the three device definitions, and the result looks fine in
info qtree.

A brief hint at why you would want a PCIe switch in the comment would
perhaps be nice.

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [Qemu-devel] [PATCH] q35: Add PCIe switch to example q35 configuration
  2013-08-20 18:21 [Qemu-devel] [PATCH] q35: Add PCIe switch to example q35 configuration Alex Williamson
  2013-08-21  9:31 ` Markus Armbruster
@ 2013-08-21  9:39 ` Michael S. Tsirkin
  1 sibling, 0 replies; 3+ messages in thread
From: Michael S. Tsirkin @ 2013-08-21  9:39 UTC (permalink / raw)
  To: Alex Williamson; +Cc: armbru, qemu-devel, kraxel

On Tue, Aug 20, 2013 at 12:21:57PM -0600, Alex Williamson wrote:
> Signed-off-by: Alex Williamson <alex.williamson@redhat.com>

Thanks, applied.

> ---
>  docs/q35-chipset.cfg |   23 +++++++++++++++++++++++
>  1 file changed, 23 insertions(+)
> 
> diff --git a/docs/q35-chipset.cfg b/docs/q35-chipset.cfg
> index 1b6efc0..e4ddb7d 100644
> --- a/docs/q35-chipset.cfg
> +++ b/docs/q35-chipset.cfg
> @@ -91,6 +91,29 @@
>    port = "4"
>    chassis = "4"
>  
> +##
> +# Example PCIe switch with two downstream ports
> +#
> +#[device "pcie-switch-upstream-port-1"]
> +#  driver = "x3130-upstream"
> +#  bus = "ich9-pcie-port-4"
> +#  addr = "00.0"
> +#
> +#[device "pcie-switch-downstream-port-1-1"]
> +#  driver = "xio3130-downstream"
> +#  multifunction = "on"
> +#  bus = "pcie-switch-upstream-port-1"
> +#  addr = "00.0"
> +#  port = "1"
> +#  chassis = "5"
> +#
> +#[device "pcie-switch-downstream-port-1-2"]
> +#  driver = "xio3130-downstream"
> +#  multifunction = "on"
> +#  bus = "pcie-switch-upstream-port-1"
> +#  addr = "00.1"
> +#  port = "1"
> +#  chassis = "6"
>  
>  [device "ich9-ehci-1"]
>    driver = "ich9-usb-ehci1"

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2013-08-21  9:37 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-08-20 18:21 [Qemu-devel] [PATCH] q35: Add PCIe switch to example q35 configuration Alex Williamson
2013-08-21  9:31 ` Markus Armbruster
2013-08-21  9:39 ` Michael S. Tsirkin

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).