From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49677) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VC7hC-00027Z-HY for qemu-devel@nongnu.org; Wed, 21 Aug 2013 08:39:36 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VC7h6-0006Xu-IT for qemu-devel@nongnu.org; Wed, 21 Aug 2013 08:39:30 -0400 Received: from mx1.redhat.com ([209.132.183.28]:61446) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VC7h6-0006Xi-9K for qemu-devel@nongnu.org; Wed, 21 Aug 2013 08:39:24 -0400 Date: Wed, 21 Aug 2013 15:41:11 +0300 From: "Michael S. Tsirkin" Message-ID: <20130821124111.GA7872@redhat.com> References: <1377031745-3654-1-git-send-email-ehabkost@redhat.com> <20130820212032.GA29871@redhat.com> <20130821123013.GL14443@otherpad.lan.raisama.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20130821123013.GL14443@otherpad.lan.raisama.net> Subject: Re: [Qemu-devel] [PATCH 0/6] pc init & compat function cleanup List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eduardo Habkost Cc: Paolo Bonzini , Anthony Liguori , Gerd Hoffmann , qemu-devel@nongnu.org, Andreas =?iso-8859-1?Q?F=E4rber?= On Wed, Aug 21, 2013 at 09:30:38AM -0300, Eduardo Habkost wrote: > On Wed, Aug 21, 2013 at 12:20:32AM +0300, Michael S. Tsirkin wrote: > > On Tue, Aug 20, 2013 at 05:48:59PM -0300, Eduardo Habkost wrote: > > > This is a follow-up to the patch submitted by Michael (patch 1/6 in this > > > series), to make the pc compat initialization code simpler and easier to > > > eventually remove code duplication between pc_piix.c and pc_q35.c. > > > > Eduardo this does not seem to apply to either master or my tree. > > Could you rebase and make it apply to my tree? > > git://git.kernel.org/pub/scm/virt/kvm/mst/qemu.git pci > > For reference, I have used commit > f202039811d8746b0586d2fd5f61de6c8cf68056 as base. I could apply the > series cleanly (copying from my qemu-devel mailbox and not my git tree, > just in case) on top of current master (commit > ecfe10c9a6f9bc77d0e4b7eb5d0f5d61e8fbaed8). Weird, all I have is: $ git log --oneline ecfe10c9a6f9bc77d0e4b7eb5d0f5d61e8fbaed8.. 4b38e98 q35: Add PCIe switch to example q35 configuration 04920fc loader: store FW CFG ROM files in RAM 0851c9f arch_init: align MR size to target page size c0b4cc1 pc: cleanup 1.4 compat support > But there are some conflicts with your pci tree, I will make a rebased > version. Pls do. > > > > > Eduardo Habkost (5): > > > pc: Kill pc_init_pci_1_0() > > > pc: Create pc_compat_*() functions > > > pc: pc_compat_1_4() now can call pc_compat_1_5() > > > pc_piix: Kill pc_init1() memory region args > > > pc_piix: Pass QEMUMachineInitArgs to pc_init1() > > > > > > Michael S. Tsirkin (1): > > > pc: cleanup 1.4 compat support > > > > > > hw/i386/pc_piix.c | 117 ++++++++++++++++++++++++++---------------------------- > > > hw/i386/pc_q35.c | 29 +++++++++++--- > > > 2 files changed, 79 insertions(+), 67 deletions(-) > > > > > > -- > > > 1.8.3.1 > > -- > Eduardo