From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37254) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VCBaD-0005NH-1p for qemu-devel@nongnu.org; Wed, 21 Aug 2013 12:48:37 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VCBa9-0005Pw-9o for qemu-devel@nongnu.org; Wed, 21 Aug 2013 12:48:33 -0400 Received: from mx1.redhat.com ([209.132.183.28]:59901) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VCBa9-0005Ma-10 for qemu-devel@nongnu.org; Wed, 21 Aug 2013 12:48:29 -0400 Date: Wed, 21 Aug 2013 17:48:17 +0100 From: "Daniel P. Berrange" Message-ID: <20130821164817.GC10012@redhat.com> References: <1377103396-24307-1-git-send-email-pbonzini@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <1377103396-24307-1-git-send-email-pbonzini@redhat.com> Subject: Re: [Qemu-devel] [RFC PATCH v2 0/3] Start fixing the pvpanic mess Reply-To: "Daniel P. Berrange" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: pkrempa@redhat.com, marcel.a@redhat.com, libvir-list@redhat.com, lersek@redhat.com, mst@redhat.com, qemu-devel@nongnu.org, armbru@redhat.com, rhod@redhat.com, kraxel@redhat.com, anthony@codemonkey.ws, hutao@cn.fujitsu.com, lcapitulino@redhat.com, afaerber@suse.de On Wed, Aug 21, 2013 at 06:43:13PM +0200, Paolo Bonzini wrote: > The pvpanic mess is even bigger than anticipated. Let's fix the monitor's > behavior (patch 1), get rid of all traces that the broken pvpanic existed > (patch 2), and give it a new name so that libvirt can detect a design > that works (patch 3). > > All downstreams are urged to apply patches 1+2 as soon as they are > merged in QEMU. > > Still, there are still other problems to solve. > > In QEMU, exposing "-device isa-pvpanic" in the ACPI tables. Quite frankly > I don't have the time to fix this. We have ~3 months though. Patch 3 > should not be applied until it is fixed. > > Also, libvirt needs to know under which circumstances to add "-device > isa-pvpanic", besides obviously the availability of the device. > > IMHO it is just too complicated to retrofit all complications in > . In fact, I suspect would match more closely QEMU's > "internal error" state, and it would be quite useful to add that to the > QEMU driver. > > Thus, libvirt could add support for an element with the > following values: No, is the right thing to be using for this from libvirt's pov & I don't think we should invent something new. The element has always been intended to represent handling of guest panics, not qemu internal errors. Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|