From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41007) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VCBl4-0001RK-AO for qemu-devel@nongnu.org; Wed, 21 Aug 2013 12:59:52 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VCBky-0001dm-BF for qemu-devel@nongnu.org; Wed, 21 Aug 2013 12:59:46 -0400 Received: from mx1.redhat.com ([209.132.183.28]:21376) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VCBky-0001dg-2f for qemu-devel@nongnu.org; Wed, 21 Aug 2013 12:59:40 -0400 Date: Wed, 21 Aug 2013 20:01:20 +0300 From: "Michael S. Tsirkin" Message-ID: <20130821170120.GA12305@redhat.com> References: <1377103396-24307-1-git-send-email-pbonzini@redhat.com> <1377103396-24307-4-git-send-email-pbonzini@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1377103396-24307-4-git-send-email-pbonzini@redhat.com> Subject: Re: [Qemu-devel] [PATCH 3/3] pvpanic: rename to isa-pvpanic List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: pkrempa@redhat.com, marcel.a@redhat.com, libvir-list@redhat.com, lersek@redhat.com, qemu-devel@nongnu.org, armbru@redhat.com, rhod@redhat.com, kraxel@redhat.com, anthony@codemonkey.ws, hutao@cn.fujitsu.com, lcapitulino@redhat.com, afaerber@suse.de On Wed, Aug 21, 2013 at 06:43:16PM +0200, Paolo Bonzini wrote: > The pvpanic situation is already messed up enough. Let us give our > libvirt friends an easy indication that we have untied our side. > > Not-yet-signed-off-by: Paolo Bonzini > ... because we first have to determine how to expose the device's existence > in the ACPI tables or in fw_cfg. > > Signed-off-by: Paolo Bonzini So it's isa-pvpanic meaning "I-am-sure-this-is-the-last-bug-pvpanic" If we feel there's need to give libvirt a way to do introspection into QEMU bugs, let's architect one. Randomly renaming devices in the vain hope it's the last major bug is not it. NACK > --- > hw/misc/pvpanic.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/hw/misc/pvpanic.c b/hw/misc/pvpanic.c > index 1928cc9..b53011d 100644 > --- a/hw/misc/pvpanic.c > +++ b/hw/misc/pvpanic.c > @@ -27,7 +27,7 @@ > /* The pv event value */ > #define PVPANIC_PANICKED (1 << PVPANIC_F_PANICKED) > > -#define TYPE_ISA_PVPANIC_DEVICE "pvpanic" > +#define TYPE_ISA_PVPANIC_DEVICE "isa-pvpanic" > #define ISA_PVPANIC_DEVICE(obj) \ > OBJECT_CHECK(PVPanicState, (obj), TYPE_ISA_PVPANIC_DEVICE) > > -- > 1.8.3.1