From: Stefan Hajnoczi <stefanha@gmail.com>
To: Fam Zheng <famz@redhat.com>
Cc: kwolf@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com
Subject: Re: [Qemu-devel] [PATCH] block: better error message for read only format name
Date: Thu, 22 Aug 2013 14:30:09 +0200 [thread overview]
Message-ID: <20130822123009.GA23367@stefanha-thinkpad.redhat.com> (raw)
In-Reply-To: <1377157019-9267-1-git-send-email-famz@redhat.com>
On Thu, Aug 22, 2013 at 03:36:59PM +0800, Fam Zheng wrote:
> When user tries to use read-only whitelist format in the command line
> option, failure message was "'foo' invalid format". It might be invalid
> only for writable, but valid for read-only, so it is confusing. Give the
> user easier to understand information.
>
> Signed-off-by: Fam Zheng <famz@redhat.com>
> ---
> blockdev.c | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
Thanks, applied to my block tree:
https://github.com/stefanha/qemu/commits/block
Stefan
prev parent reply other threads:[~2013-08-22 12:30 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-22 7:36 [Qemu-devel] [PATCH] block: better error message for read only format name Fam Zheng
2013-08-22 12:30 ` Stefan Hajnoczi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130822123009.GA23367@stefanha-thinkpad.redhat.com \
--to=stefanha@gmail.com \
--cc=famz@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).