* [Qemu-devel] [PATCH] block: better error message for read only format name
@ 2013-08-22 7:36 Fam Zheng
2013-08-22 12:30 ` Stefan Hajnoczi
0 siblings, 1 reply; 2+ messages in thread
From: Fam Zheng @ 2013-08-22 7:36 UTC (permalink / raw)
To: qemu-devel; +Cc: kwolf, famz, stefanha
When user tries to use read-only whitelist format in the command line
option, failure message was "'foo' invalid format". It might be invalid
only for writable, but valid for read-only, so it is confusing. Give the
user easier to understand information.
Signed-off-by: Fam Zheng <famz@redhat.com>
---
blockdev.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/blockdev.c b/blockdev.c
index bc7016a..d3500c6 100644
--- a/blockdev.c
+++ b/blockdev.c
@@ -487,7 +487,11 @@ static DriveInfo *blockdev_init(QemuOpts *all_opts,
drv = bdrv_find_whitelisted_format(buf, ro);
if (!drv) {
- error_report("'%s' invalid format", buf);
+ if (!ro && bdrv_find_whitelisted_format(buf, !ro)) {
+ error_report("'%s' can be only used as read-only device.", buf);
+ } else {
+ error_report("'%s' invalid format", buf);
+ }
return NULL;
}
}
--
1.8.3.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [Qemu-devel] [PATCH] block: better error message for read only format name
2013-08-22 7:36 [Qemu-devel] [PATCH] block: better error message for read only format name Fam Zheng
@ 2013-08-22 12:30 ` Stefan Hajnoczi
0 siblings, 0 replies; 2+ messages in thread
From: Stefan Hajnoczi @ 2013-08-22 12:30 UTC (permalink / raw)
To: Fam Zheng; +Cc: kwolf, qemu-devel, stefanha
On Thu, Aug 22, 2013 at 03:36:59PM +0800, Fam Zheng wrote:
> When user tries to use read-only whitelist format in the command line
> option, failure message was "'foo' invalid format". It might be invalid
> only for writable, but valid for read-only, so it is confusing. Give the
> user easier to understand information.
>
> Signed-off-by: Fam Zheng <famz@redhat.com>
> ---
> blockdev.c | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
Thanks, applied to my block tree:
https://github.com/stefanha/qemu/commits/block
Stefan
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-08-22 12:30 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-08-22 7:36 [Qemu-devel] [PATCH] block: better error message for read only format name Fam Zheng
2013-08-22 12:30 ` Stefan Hajnoczi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).