From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47491) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VCU1p-0008WO-Ln for qemu-devel@nongnu.org; Thu, 22 Aug 2013 08:30:24 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VCU1k-0001fW-CG for qemu-devel@nongnu.org; Thu, 22 Aug 2013 08:30:17 -0400 Received: from mail-ee0-x233.google.com ([2a00:1450:4013:c00::233]:32922) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VCU1k-0001fI-5d for qemu-devel@nongnu.org; Thu, 22 Aug 2013 08:30:12 -0400 Received: by mail-ee0-f51.google.com with SMTP id c1so889664eek.10 for ; Thu, 22 Aug 2013 05:30:11 -0700 (PDT) Date: Thu, 22 Aug 2013 14:30:09 +0200 From: Stefan Hajnoczi Message-ID: <20130822123009.GA23367@stefanha-thinkpad.redhat.com> References: <1377157019-9267-1-git-send-email-famz@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1377157019-9267-1-git-send-email-famz@redhat.com> Subject: Re: [Qemu-devel] [PATCH] block: better error message for read only format name List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Fam Zheng Cc: kwolf@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com On Thu, Aug 22, 2013 at 03:36:59PM +0800, Fam Zheng wrote: > When user tries to use read-only whitelist format in the command line > option, failure message was "'foo' invalid format". It might be invalid > only for writable, but valid for read-only, so it is confusing. Give the > user easier to understand information. > > Signed-off-by: Fam Zheng > --- > blockdev.c | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) Thanks, applied to my block tree: https://github.com/stefanha/qemu/commits/block Stefan