* [Qemu-devel] [PATCH v4] usb/dev-hid: Modified usb-tablet category from Misc to Input
@ 2013-08-22 17:11 Marcel Apfelbaum
2013-08-25 10:23 ` Michael S. Tsirkin
2013-08-28 11:13 ` Gerd Hoffmann
0 siblings, 2 replies; 4+ messages in thread
From: Marcel Apfelbaum @ 2013-08-22 17:11 UTC (permalink / raw)
To: qemu-devel
Cc: aliguori, mst, Marcel Apfelbaum, armbru, qemu-stable, kraxel,
pbonzini, afaerber
usb-tablet device was wrongly assigned to Misc category
Reported-by: Markus Armbruster <armbru@redhat.com>
Cc: qemu-stable@nongnu.org
Signed-off-by: Marcel Apfelbaum <marcel.a@redhat.com>
Reviewed-by: Andreas Färber <afaerber@suse.de>
---
Changes from v3:
- Added "Cc: qemu-stable@nongnu.org" this time in the sign-off area ...
Changes from v2:
- Corrected spelling
Changes from v1:
- Add cc to qemu-stable and Gerd Hoffmann
- Changed subject prefix from hw to usb/dev-hid
hw/usb/dev-hid.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/usb/dev-hid.c b/hw/usb/dev-hid.c
index 66c6331..5956720 100644
--- a/hw/usb/dev-hid.c
+++ b/hw/usb/dev-hid.c
@@ -658,7 +658,7 @@ static void usb_tablet_class_initfn(ObjectClass *klass, void *data)
uc->product_desc = "QEMU USB Tablet";
dc->vmsd = &vmstate_usb_ptr;
dc->props = usb_tablet_properties;
- set_bit(DEVICE_CATEGORY_MISC, dc->categories);
+ set_bit(DEVICE_CATEGORY_INPUT, dc->categories);
}
static const TypeInfo usb_tablet_info = {
--
1.8.3.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [PATCH v4] usb/dev-hid: Modified usb-tablet category from Misc to Input
2013-08-22 17:11 [Qemu-devel] [PATCH v4] usb/dev-hid: Modified usb-tablet category from Misc to Input Marcel Apfelbaum
@ 2013-08-25 10:23 ` Michael S. Tsirkin
2013-08-28 8:13 ` Marcel Apfelbaum
2013-08-28 11:13 ` Gerd Hoffmann
1 sibling, 1 reply; 4+ messages in thread
From: Michael S. Tsirkin @ 2013-08-25 10:23 UTC (permalink / raw)
To: Marcel Apfelbaum
Cc: aliguori, armbru, qemu-stable, qemu-devel, kraxel, pbonzini,
afaerber
On Thu, Aug 22, 2013 at 08:11:36PM +0300, Marcel Apfelbaum wrote:
> usb-tablet device was wrongly assigned to Misc category
>
> Reported-by: Markus Armbruster <armbru@redhat.com>
> Cc: qemu-stable@nongnu.org
> Signed-off-by: Marcel Apfelbaum <marcel.a@redhat.com>
> Reviewed-by: Andreas Färber <afaerber@suse.de>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
> ---
> Changes from v3:
> - Added "Cc: qemu-stable@nongnu.org" this time in the sign-off area ...
> Changes from v2:
> - Corrected spelling
> Changes from v1:
> - Add cc to qemu-stable and Gerd Hoffmann
> - Changed subject prefix from hw to usb/dev-hid
>
> hw/usb/dev-hid.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/usb/dev-hid.c b/hw/usb/dev-hid.c
> index 66c6331..5956720 100644
> --- a/hw/usb/dev-hid.c
> +++ b/hw/usb/dev-hid.c
> @@ -658,7 +658,7 @@ static void usb_tablet_class_initfn(ObjectClass *klass, void *data)
> uc->product_desc = "QEMU USB Tablet";
> dc->vmsd = &vmstate_usb_ptr;
> dc->props = usb_tablet_properties;
> - set_bit(DEVICE_CATEGORY_MISC, dc->categories);
> + set_bit(DEVICE_CATEGORY_INPUT, dc->categories);
> }
>
> static const TypeInfo usb_tablet_info = {
> --
> 1.8.3.1
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [PATCH v4] usb/dev-hid: Modified usb-tablet category from Misc to Input
2013-08-25 10:23 ` Michael S. Tsirkin
@ 2013-08-28 8:13 ` Marcel Apfelbaum
0 siblings, 0 replies; 4+ messages in thread
From: Marcel Apfelbaum @ 2013-08-28 8:13 UTC (permalink / raw)
To: qemu-devel
Cc: aliguori, Michael S. Tsirkin, Markus Armbruster, kraxel, pbonzini,
afaerber
On Sun, 2013-08-25 at 13:23 +0300, Michael S. Tsirkin wrote:
> On Thu, Aug 22, 2013 at 08:11:36PM +0300, Marcel Apfelbaum wrote:
> > usb-tablet device was wrongly assigned to Misc category
> >
> > Reported-by: Markus Armbruster <armbru@redhat.com>
> > Cc: qemu-stable@nongnu.org
> > Signed-off-by: Marcel Apfelbaum <marcel.a@redhat.com>
> > Reviewed-by: Andreas Färber <afaerber@suse.de>
>
> Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
pull? :)
Marcel
>
> > ---
> > Changes from v3:
> > - Added "Cc: qemu-stable@nongnu.org" this time in the sign-off area ...
> > Changes from v2:
> > - Corrected spelling
> > Changes from v1:
> > - Add cc to qemu-stable and Gerd Hoffmann
> > - Changed subject prefix from hw to usb/dev-hid
> >
> > hw/usb/dev-hid.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/hw/usb/dev-hid.c b/hw/usb/dev-hid.c
> > index 66c6331..5956720 100644
> > --- a/hw/usb/dev-hid.c
> > +++ b/hw/usb/dev-hid.c
> > @@ -658,7 +658,7 @@ static void usb_tablet_class_initfn(ObjectClass *klass, void *data)
> > uc->product_desc = "QEMU USB Tablet";
> > dc->vmsd = &vmstate_usb_ptr;
> > dc->props = usb_tablet_properties;
> > - set_bit(DEVICE_CATEGORY_MISC, dc->categories);
> > + set_bit(DEVICE_CATEGORY_INPUT, dc->categories);
> > }
> >
> > static const TypeInfo usb_tablet_info = {
> > --
> > 1.8.3.1
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [PATCH v4] usb/dev-hid: Modified usb-tablet category from Misc to Input
2013-08-22 17:11 [Qemu-devel] [PATCH v4] usb/dev-hid: Modified usb-tablet category from Misc to Input Marcel Apfelbaum
2013-08-25 10:23 ` Michael S. Tsirkin
@ 2013-08-28 11:13 ` Gerd Hoffmann
1 sibling, 0 replies; 4+ messages in thread
From: Gerd Hoffmann @ 2013-08-28 11:13 UTC (permalink / raw)
To: Marcel Apfelbaum
Cc: aliguori, mst, armbru, qemu-stable, qemu-devel, pbonzini,
afaerber
On Do, 2013-08-22 at 20:11 +0300, Marcel Apfelbaum wrote:
> usb-tablet device was wrongly assigned to Misc category
Added to usb patch queue.
thanks,
Gerd
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2013-08-28 11:13 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-08-22 17:11 [Qemu-devel] [PATCH v4] usb/dev-hid: Modified usb-tablet category from Misc to Input Marcel Apfelbaum
2013-08-25 10:23 ` Michael S. Tsirkin
2013-08-28 8:13 ` Marcel Apfelbaum
2013-08-28 11:13 ` Gerd Hoffmann
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).