From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55585) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VDrmG-0005vy-08 for qemu-devel@nongnu.org; Mon, 26 Aug 2013 04:04:03 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VDrm4-0006eT-9j for qemu-devel@nongnu.org; Mon, 26 Aug 2013 04:03:55 -0400 Received: from e06smtp10.uk.ibm.com ([195.75.94.106]:36663) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VDrm4-0006e8-0O for qemu-devel@nongnu.org; Mon, 26 Aug 2013 04:03:44 -0400 Received: from /spool/local by e06smtp10.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Mon, 26 Aug 2013 09:00:37 +0100 Date: Mon, 26 Aug 2013 10:03:35 +0200 From: Cornelia Huck Message-ID: <20130826100335.0ee36500@gondolin> In-Reply-To: <1377302436-25193-13-git-send-email-afaerber@suse.de> References: <1377302436-25193-1-git-send-email-afaerber@suse.de> <1377302436-25193-13-git-send-email-afaerber@suse.de> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 12/16] qdev: Pass size to qbus_create_inplace() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Andreas =?UTF-8?B?RsOkcmJlcg==?= Cc: Kevin Wolf , peter.maydell@linaro.org, "Michael S. Tsirkin" , "open list:New World" , qemu-devel@nongnu.org, Alexander Graf , "Vassili Karpov (malc)" , Gerd Hoffmann , anthony@codemonkey.ws, Paolo Bonzini , Amit Shah , Igor Mammedov , Richard Henderson On Sat, 24 Aug 2013 02:00:32 +0200 Andreas F=C3=A4rber wrote: > To be passed to object_initialize(). >=20 > Since commit 39355c3826f5d9a2eb1ce3dc9b4cdd68893769d6 the argument is > void*, so drop some superfluous (BusState *) casts or direct parent > field usages. >=20 > Signed-off-by: Andreas F=C3=A4rber > --- > hw/audio/intel-hda.c | 2 +- > hw/char/ipack.c | 2 +- > hw/char/virtio-serial-bus.c | 4 ++-- > hw/core/qdev.c | 2 +- > hw/core/sysbus.c | 4 ++-- > hw/cpu/icc_bus.c | 3 ++- > hw/ide/qdev.c | 2 +- > hw/misc/macio/cuda.c | 4 ++-- > hw/pci/pci.c | 2 +- > hw/pci/pci_bridge.c | 3 ++- > hw/s390x/event-facility.c | 4 ++-- > hw/s390x/s390-virtio-bus.c | 4 ++-- > hw/s390x/virtio-ccw.c | 4 ++-- > hw/scsi/scsi-bus.c | 2 +- > hw/usb/bus.c | 2 +- > hw/usb/dev-smartcard-reader.c | 3 ++- > hw/virtio/virtio-mmio.c | 2 +- > hw/virtio/virtio-pci.c | 2 +- > include/hw/qdev-core.h | 2 +- > 19 files changed, 28 insertions(+), 25 deletions(-) >=20 > diff --git a/hw/s390x/s390-virtio-bus.c b/hw/s390x/s390-virtio-bus.c > index 579adbc..e95b831 100644 > --- a/hw/s390x/s390-virtio-bus.c > +++ b/hw/s390x/s390-virtio-bus.c > @@ -699,8 +699,8 @@ static void virtio_s390_bus_new(VirtioBusState *bus, = size_t bus_size, > BusState *qbus; > char virtio_bus_name[] =3D "virtio-bus"; >=20 > - qbus_create_inplace((BusState *)bus, TYPE_VIRTIO_S390_BUS, qdev, > - virtio_bus_name); > + qbus_create_inplace((BusState *)bus, bus_size, TYPE_VIRTIO_S390_BUS, > + qdev, virtio_bus_name); > qbus =3D BUS(bus); > qbus->allow_hotplug =3D 1; > } > diff --git a/hw/s390x/virtio-ccw.c b/hw/s390x/virtio-ccw.c > index 36cbf42..cf7075e 100644 > --- a/hw/s390x/virtio-ccw.c > +++ b/hw/s390x/virtio-ccw.c > @@ -1297,8 +1297,8 @@ static void virtio_ccw_bus_new(VirtioBusState *bus,= size_t bus_size, > BusState *qbus; > char virtio_bus_name[] =3D "virtio-bus"; >=20 > - qbus_create_inplace((BusState *)bus, TYPE_VIRTIO_CCW_BUS, qdev, > - virtio_bus_name); > + qbus_create_inplace((BusState *)bus, bus_size, TYPE_VIRTIO_CCW_BUS, > + qdev, virtio_bus_name); > qbus =3D BUS(bus); > qbus->allow_hotplug =3D 1; > } You'll probably want to drop the superflous casts here as well :)