From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:44816)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1VDzAH-0003Zs-OC
	for qemu-devel@nongnu.org; Mon, 26 Aug 2013 11:57:18 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1VDzAC-0004ex-T1
	for qemu-devel@nongnu.org; Mon, 26 Aug 2013 11:57:13 -0400
Date: Mon, 26 Aug 2013 11:48:59 -0400
From: Luiz Capitulino <lcapitulino@redhat.com>
Message-ID: <20130826114859.640f5d87@redhat.com>
In-Reply-To: <1377199809-12208-1-git-send-email-sw@weilnetz.de>
References: <1377199809-12208-1-git-send-email-sw@weilnetz.de>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] monitor: Add missing attributes to local
	function
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefan Weil <sw@weilnetz.de>
Cc: qemu-trivial <qemu-trivial@nongnu.org>, qemu-devel <qemu-devel@nongnu.org>

On Thu, 22 Aug 2013 21:30:09 +0200
Stefan Weil <sw@weilnetz.de> wrote:

> Function expr_error gets a format string and variable arguments like printf.
> It also never returns. Add the necessary attributes.
> 
> Signed-off-by: Stefan Weil <sw@weilnetz.de>

Applied to the qmp branch, thanks.

> ---
>  monitor.c |    3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/monitor.c b/monitor.c
> index da9c9a2..6413d44 100644
> --- a/monitor.c
> +++ b/monitor.c
> @@ -3171,7 +3171,8 @@ static const MonitorDef monitor_defs[] = {
>      { NULL },
>  };
>  
> -static void expr_error(Monitor *mon, const char *fmt, ...)
> +static void GCC_FMT_ATTR(2, 3) QEMU_NORETURN
> +expr_error(Monitor *mon, const char *fmt, ...)
>  {
>      va_list ap;
>      va_start(ap, fmt);