From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36440) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VEECl-0000js-Qd for qemu-devel@nongnu.org; Tue, 27 Aug 2013 04:00:53 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VEECd-0006BV-L1 for qemu-devel@nongnu.org; Tue, 27 Aug 2013 04:00:47 -0400 Received: from mx1.redhat.com ([209.132.183.28]:9245) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VEECd-0006BF-Cj for qemu-devel@nongnu.org; Tue, 27 Aug 2013 04:00:39 -0400 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r7R80aJ8000633 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Tue, 27 Aug 2013 04:00:37 -0400 Date: Tue, 27 Aug 2013 10:00:42 +0200 From: Kevin Wolf Message-ID: <20130827080042.GC3181@dhcp-200-207.str.redhat.com> References: <1376904333-30336-1-git-send-email-kwolf@redhat.com> <5217420C.7060906@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline In-Reply-To: <5217420C.7060906@redhat.com> Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH] qcow2: Change default for new images to compat=1.1 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?iso-8859-1?B?SuFu?= Tomko Cc: qemu-devel@nongnu.org, stefanha@redhat.com Am 23.08.2013 um 13:05 hat J=E1n Tomko geschrieben: > On 08/19/2013 11:25 AM, Kevin Wolf wrote: > > By the time that qemu 1.7 will be released, enough time will has pass= ed > > since qemu 1.1, which is the first version to understand version 3 > > images, that changing the default shouldn't hurt many people any more > > and the benefits of using the new format outweigh the pain. > >=20 > > qemu-iotests already runs with compat=3D1.1 by default. > >=20 > > Signed-off-by: Kevin Wolf > > --- > > block/qcow2.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > >=20 > > diff --git a/block/qcow2.c b/block/qcow2.c > > index 3376901..42ea7ec 100644 > > --- a/block/qcow2.c > > +++ b/block/qcow2.c > > @@ -1402,7 +1402,7 @@ static int qcow2_create(const char *filename, Q= EMUOptionParameter *options) > > int flags =3D 0; > > size_t cluster_size =3D DEFAULT_CLUSTER_SIZE; > > int prealloc =3D 0; > > - int version =3D 2; > > + int version =3D 3; > > =20 > > /* Read out options */ > > while (options && options->name) { > > >=20 > This does not affect qemu-img (or bdrv_img_create), as it gets overwrit= ten > with 2 when BLOCK_OPT_COMPAT_LEVEL is present in options, but the value= is NULL. Whoops... Thanks for catching this, I'll send a v2. > Should this go into qcow2_create_options[] as well? Not sure what you want to change in the options array? It doesn't seem to denote a default. Kevin