From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39555) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VEERr-0002Ml-PK for qemu-devel@nongnu.org; Tue, 27 Aug 2013 04:16:32 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VEERg-0002JS-VK for qemu-devel@nongnu.org; Tue, 27 Aug 2013 04:16:23 -0400 Received: from e28smtp03.in.ibm.com ([122.248.162.3]:38805) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VEERg-0002JD-80 for qemu-devel@nongnu.org; Tue, 27 Aug 2013 04:16:12 -0400 Received: from /spool/local by e28smtp03.in.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 27 Aug 2013 13:38:18 +0530 Received: from d28relay03.in.ibm.com (d28relay03.in.ibm.com [9.184.220.60]) by d28dlp01.in.ibm.com (Postfix) with ESMTP id 6EEC7E0053 for ; Tue, 27 Aug 2013 13:46:43 +0530 (IST) Received: from d28av01.in.ibm.com (d28av01.in.ibm.com [9.184.220.63]) by d28relay03.in.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id r7R8HiGm40435956 for ; Tue, 27 Aug 2013 13:47:45 +0530 Received: from d28av01.in.ibm.com (localhost [127.0.0.1]) by d28av01.in.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id r7R8G7ha018596 for ; Tue, 27 Aug 2013 13:46:07 +0530 Date: Tue, 27 Aug 2013 13:46:31 +0530 From: Bharata B Rao Message-ID: <20130827081631.GA30031@in.ibm.com> References: <1377582781-640-1-git-send-email-bharata@linux.vnet.ibm.com> <521C4DFD.30805@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <521C4DFD.30805@redhat.com> Subject: Re: [Qemu-devel] [PATCH] gluster: Abort on AIO completion failure Reply-To: bharata@linux.vnet.ibm.com List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: kwolf@redhat.com, asias@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com On Tue, Aug 27, 2013 at 08:58:05AM +0200, Paolo Bonzini wrote: > > diff --git a/block/gluster.c b/block/gluster.c > > index 46f36f8..942154a 100644 > > --- a/block/gluster.c > > +++ b/block/gluster.c > > @@ -427,20 +427,9 @@ static void gluster_finish_aiocb(struct glfs_fd *fd, ssize_t ret, void *arg) > > /* > > * Gluster AIO callback thread failed to notify the waiting > > * QEMU thread about IO completion. > > - * > > - * Complete this IO request and make the disk inaccessible for > > - * subsequent reads and writes. > > */ > > - error_report("Gluster failed to notify QEMU about IO completion"); > > - > > - qemu_mutex_lock_iothread(); /* We are in gluster thread context */ > > - acb->common.cb(acb->common.opaque, -EIO); > > - qemu_aio_release(acb); > > - close(s->fds[GLUSTER_FD_READ]); > > - close(s->fds[GLUSTER_FD_WRITE]); > > - qemu_aio_set_fd_handler(s->fds[GLUSTER_FD_READ], NULL, NULL, NULL); > > - bs->drv = NULL; /* Make the disk inaccessible */ > > - qemu_mutex_unlock_iothread(); > > + error_report("Gluster AIO completion failed"); > > Still, considering everyone can be wrong, adding the errno here is > probably not a bad idea. :) Sent v1 with errno added. Regards, Bharata.