From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:58681)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1VEJpb-0002Tu-2V
	for qemu-devel@nongnu.org; Tue, 27 Aug 2013 10:01:21 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1VEJpV-0000sC-3Z
	for qemu-devel@nongnu.org; Tue, 27 Aug 2013 10:01:15 -0400
Received: from mx1.redhat.com ([209.132.183.28]:26818)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1VEJpU-0000rB-SC
	for qemu-devel@nongnu.org; Tue, 27 Aug 2013 10:01:09 -0400
Date: Tue, 27 Aug 2013 16:01:15 +0200
From: Kevin Wolf <kwolf@redhat.com>
Message-ID: <20130827140115.GK648@dhcp-200-207.str.redhat.com>
References: <1376368326-7433-1-git-send-email-wdongxu@linux.vnet.ibm.com>
	<1376368326-7433-6-git-send-email-wdongxu@linux.vnet.ibm.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1376368326-7433-6-git-send-email-wdongxu@linux.vnet.ibm.com>
Subject: Re: [Qemu-devel] [PATCH V18 05/25] qemu-option: opt->str store
 digit, without suffixes
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Dong Xu Wang <wdongxu@linux.vnet.ibm.com>
Cc: wdongxu@cn.ibm.com, qemu-devel@nongnu.org, stefanha@redhat.com

Am 13.08.2013 um 06:31 hat Dong Xu Wang geschrieben:
> To produce same output while using "qemu-img create", opt->str
> should store pure digit, without suffixes.
> 
> Signed-off-by: Dong Xu Wang <wdongxu@linux.vnet.ibm.com>
> ---
>  util/qemu-option.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/util/qemu-option.c b/util/qemu-option.c
> index b939e8a..861929d 100644
> --- a/util/qemu-option.c
> +++ b/util/qemu-option.c
> @@ -675,6 +675,8 @@ static void qemu_opt_parse(QemuOpt *opt, Error **errp)
>          break;
>      case QEMU_OPT_SIZE:
>          parse_option_size(opt->name, opt->str, &opt->value.uint, errp);
> +        g_free((char *)opt->str);
> +        opt->str = g_strdup(stringify(opt->value_uint));

This is wrong, stringify() is a macro at compile time. You get
"opt->value_uint" for any option here.

You're probably looking for g_strdup_printf().

Kevin