From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60686) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VEJxU-000637-1F for qemu-devel@nongnu.org; Tue, 27 Aug 2013 10:09:30 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VEJxN-0003QQ-OS for qemu-devel@nongnu.org; Tue, 27 Aug 2013 10:09:23 -0400 Received: from mx1.redhat.com ([209.132.183.28]:39685) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VEJxN-0003QL-GN for qemu-devel@nongnu.org; Tue, 27 Aug 2013 10:09:17 -0400 Date: Tue, 27 Aug 2013 16:08:36 +0200 From: Kevin Wolf Message-ID: <20130827140836.GL648@dhcp-200-207.str.redhat.com> References: <1376368326-7433-1-git-send-email-wdongxu@linux.vnet.ibm.com> <1376368326-7433-7-git-send-email-wdongxu@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1376368326-7433-7-git-send-email-wdongxu@linux.vnet.ibm.com> Subject: Re: [Qemu-devel] [PATCH V18 06/25] add interface to block List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Dong Xu Wang Cc: wdongxu@cn.ibm.com, qemu-devel@nongnu.org, stefanha@redhat.com Am 13.08.2013 um 06:31 hat Dong Xu Wang geschrieben: > Subject: Re: [PATCH V18 06/25] add interface to block This is _not_ a good subject line. > To make patches easy for reviewing, each block format is > a single patch. Add a new interface to block layer to make > sure origin code can compile and do not change any code > logic. > > Signed-off-by: Dong Xu Wang I believe that adding a second copy of each creation function actually makes reviewing harder than just changing the option parsing part in it. Kevin