From: Kevin Wolf <kwolf@redhat.com>
To: Max Reitz <mreitz@redhat.com>
Cc: qemu-devel@nongnu.org, Stefan Hajnoczi <stefanha@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 3/3] qemu-iotest: qcow2 image option amendment
Date: Wed, 28 Aug 2013 13:40:41 +0200 [thread overview]
Message-ID: <20130828114041.GF2743@dhcp-200-207.str.redhat.com> (raw)
In-Reply-To: <1377677336-15804-4-git-send-email-mreitz@redhat.com>
Am 28.08.2013 um 10:08 hat Max Reitz geschrieben:
> Add tests for qemu-img amend on qcow2 image files.
>
> Signed-off-by: Max Reitz <mreitz@redhat.com>
> ---
> This test is numbered 061 for not interfering with my "metadata overlap
> checks" series (although I will have to adapt my code to those new checks
> anyway when/if they are included in master).
> ---
> tests/qemu-iotests/061 | 121 +++++++++++++++++++
> tests/qemu-iotests/061.out | 289 +++++++++++++++++++++++++++++++++++++++++++++
> tests/qemu-iotests/group | 1 +
> 3 files changed, 411 insertions(+)
> create mode 100755 tests/qemu-iotests/061
> create mode 100644 tests/qemu-iotests/061.out
The existing cases look good. I would add some _check_test_img calls
after each amendment, and perhaps include a few cases with non-standard
cluster_size etc. during image creation (which would show that your TODO
isn't addressed yet).
Kevin
next prev parent reply other threads:[~2013-08-28 11:40 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-28 8:08 [Qemu-devel] [PATCH 0/3] block/qcow2: Image file option amendment Max Reitz
2013-08-28 8:08 ` [Qemu-devel] [PATCH 1/3] block: " Max Reitz
2013-08-28 10:03 ` Kevin Wolf
2013-08-28 12:22 ` Eric Blake
2013-08-28 12:26 ` Kevin Wolf
2013-08-28 8:08 ` [Qemu-devel] [PATCH 2/3] qcow2: Implement bdrv_amend_options Max Reitz
2013-08-28 11:06 ` Kevin Wolf
2013-08-28 11:39 ` Max Reitz
2013-08-28 11:48 ` Kevin Wolf
2013-08-28 12:05 ` Max Reitz
2013-08-28 12:12 ` Kevin Wolf
2013-08-28 8:08 ` [Qemu-devel] [PATCH 3/3] qemu-iotest: qcow2 image option amendment Max Reitz
2013-08-28 11:40 ` Kevin Wolf [this message]
2013-08-28 11:47 ` Max Reitz
2013-08-28 11:54 ` Kevin Wolf
2013-08-28 12:06 ` Max Reitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130828114041.GF2743@dhcp-200-207.str.redhat.com \
--to=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).