From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:51209)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1VEeox-0002Mo-79
	for qemu-devel@nongnu.org; Wed, 28 Aug 2013 08:26:03 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1VEeor-0006SR-4S
	for qemu-devel@nongnu.org; Wed, 28 Aug 2013 08:25:59 -0400
Received: from mx1.redhat.com ([209.132.183.28]:29129)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1VEeoq-0006SH-Fw
	for qemu-devel@nongnu.org; Wed, 28 Aug 2013 08:25:52 -0400
Received: from int-mx02.intmail.prod.int.phx2.redhat.com
	(int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r7SCPpRa025890
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <qemu-devel@nongnu.org>; Wed, 28 Aug 2013 08:25:51 -0400
Date: Wed, 28 Aug 2013 14:26:04 +0200
From: Kevin Wolf <kwolf@redhat.com>
Message-ID: <20130828122604.GJ2743@dhcp-200-207.str.redhat.com>
References: <1377677336-15804-1-git-send-email-mreitz@redhat.com>
	<1377677336-15804-2-git-send-email-mreitz@redhat.com>
	<521DEB71.1030507@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <521DEB71.1030507@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 1/3] block: Image file option amendment
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Eric Blake <eblake@redhat.com>
Cc: qemu-devel@nongnu.org, Stefan Hajnoczi <stefanha@redhat.com>, Max Reitz <mreitz@redhat.com>

Am 28.08.2013 um 14:22 hat Eric Blake geschrieben:
> On 08/28/2013 02:08 AM, Max Reitz wrote:
> > This patch adds the "amend" option to qemu-img which allows changing
> > image options on existing image files. It also adds the generic bdrv
> > implementation which is basically just a wrapper for the image format
> > specific function.
> > 
> 
> > +
> > +@item amend [-f @var{fmt}] -o @var{options} @var{filename}
> > +
> > +Amends the image format specific @var{options} for the image file
> > +@var{filename}. Only the format @code{qcow2} supports this.
> 
> The flattening of implicit zero clusters into explicit may take a
> significant amount of time; please consider adding support for -p
> (progress meter) as part of this addition.  (I'm already bothered by the
> fact that the 'commit' operation lacks a progress meter; and even
> 'check' might have cases where it could be long-running)

Good point. I think we can keep that separate, though. Let's get the
basic functionality in first, and then add a series on top that adds a
progress meter to those qemu-img subcommands for which it makes sense.

Kevin