From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:52729)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1VEgdc-00021Z-Of
	for qemu-devel@nongnu.org; Wed, 28 Aug 2013 10:22:32 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1VEgdS-0001nm-Vi
	for qemu-devel@nongnu.org; Wed, 28 Aug 2013 10:22:24 -0400
Received: from mail-ea0-f171.google.com ([209.85.215.171]:44088)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1VEgdS-0001mu-PK
	for qemu-devel@nongnu.org; Wed, 28 Aug 2013 10:22:14 -0400
Received: by mail-ea0-f171.google.com with SMTP id n15so2955751ead.2
	for <qemu-devel@nongnu.org>; Wed, 28 Aug 2013 07:21:59 -0700 (PDT)
Date: Wed, 28 Aug 2013 16:21:52 +0200
From: Stefan Hajnoczi <stefanha@gmail.com>
Message-ID: <20130828142152.GE12214@stefanha-thinkpad.muc.redhat.com>
References: <1377528172-11137-1-git-send-email-benoit@irqsave.net>
	<1377528172-11137-4-git-send-email-benoit@irqsave.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <1377528172-11137-4-git-send-email-benoit@irqsave.net>
Subject: Re: [Qemu-devel] [PATCH V6 3/5] block: Enable the new throttling
 code in the block layer.
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: =?iso-8859-1?Q?Beno=EEt?= Canet <benoit@irqsave.net>
Cc: kwolf@redhat.com, pbonzini@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com

On Mon, Aug 26, 2013 at 04:42:50PM +0200, Benoît Canet wrote:
> @@ -1887,7 +1920,8 @@ int bdrv_commit_all(void)
>   *
>   * This function should be called when a tracked request is completing.
>   */
> -static void tracked_request_end(BdrvTrackedRequest *req)
> +static void tracked_request_end(BlockDriverState *bs,
> +                                BdrvTrackedRequest *req)
>  {
>      QLIST_REMOVE(req, list);
>      qemu_co_queue_restart_all(&req->wait_queue);

This hunk is not necessary and should be dropped.