From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:53111)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1VEgfx-0003Ei-M7
	for qemu-devel@nongnu.org; Wed, 28 Aug 2013 10:24:56 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1VEgfp-0002dL-RE
	for qemu-devel@nongnu.org; Wed, 28 Aug 2013 10:24:49 -0400
Received: from mail-ea0-f170.google.com ([209.85.215.170]:46592)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1VEgfp-0002dB-Ky
	for qemu-devel@nongnu.org; Wed, 28 Aug 2013 10:24:41 -0400
Received: by mail-ea0-f170.google.com with SMTP id h14so3050799eak.1
	for <qemu-devel@nongnu.org>; Wed, 28 Aug 2013 07:24:26 -0700 (PDT)
Date: Wed, 28 Aug 2013 16:24:20 +0200
From: Stefan Hajnoczi <stefanha@gmail.com>
Message-ID: <20130828142420.GF12214@stefanha-thinkpad.muc.redhat.com>
References: <1377528172-11137-1-git-send-email-benoit@irqsave.net>
	<1377528172-11137-5-git-send-email-benoit@irqsave.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <1377528172-11137-5-git-send-email-benoit@irqsave.net>
Subject: Re: [Qemu-devel] [PATCH V6 4/5] block: Add support for throttling
 burst max in QMP and the command line.
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: =?iso-8859-1?Q?Beno=EEt?= Canet <benoit@irqsave.net>
Cc: kwolf@redhat.com, pbonzini@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com

On Mon, Aug 26, 2013 at 04:42:51PM +0200, Benoît Canet wrote:
> @@ -1404,10 +1404,16 @@ Arguments:
>  - "device": device name (json-string)
>  - "bps":  total throughput limit in bytes per second(json-int)
>  - "bps_rd":  read throughput limit in bytes per second(json-int)
> -- "bps_wr":  read throughput limit in bytes per second(json-int)
> +- "bps_wr":  write throughput limit in bytes per second(json-int)
>  - "iops":  total I/O operations per second(json-int)
>  - "iops_rd":  read I/O operations per second(json-int)
>  - "iops_wr":  write I/O operations per second(json-int)
> +- "bps_max":  total max in bytes(json-int)
> +- "bps_rd_max":  read max in bytes(json-int)
> +- "bps_wr_max":  write max in bytes(json-int)
> +- "iops_max":  total I/O operations max(json-int)
> +- "iops_rd_max":  read I/O operations max(json-int)
> +- "iops_wr_max":  write I/O operations max(json-int)

Space before (json-int).  Also we might want to document in which QEMU
version the *_max fields were added.

Stefan