From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36012) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VEivC-0001p8-48 for qemu-devel@nongnu.org; Wed, 28 Aug 2013 12:48:47 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VEiv7-0000zM-5V for qemu-devel@nongnu.org; Wed, 28 Aug 2013 12:48:42 -0400 Received: from hall.aurel32.net ([2001:470:1f0b:4a8::1]:34131) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VEiv6-0000z9-Ue for qemu-devel@nongnu.org; Wed, 28 Aug 2013 12:48:37 -0400 Date: Wed, 28 Aug 2013 18:48:22 +0200 From: Aurelien Jarno Message-ID: <20130828164822.GC23739@ohm.aurel32.net> References: <1377269838-13347-1-git-send-email-yongbok.kim@imgtec.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline In-Reply-To: <1377269838-13347-1-git-send-email-yongbok.kim@imgtec.com> Subject: Re: [Qemu-devel] [PATCH] hw: fix to display correct memory size List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Yongbok Kim Cc: leon.alrae@imgtec.com, qemu-devel@nongnu.org, critian.cuna@imgtec.com, agraf@suse.de On Fri, Aug 23, 2013 at 03:57:18PM +0100, Yongbok Kim wrote: > A parenthesis placed inappropriately caused displaying > wrong memory size bigger than 4GB. > > Signed-off-by: Yongbok Kim > --- > hw/mips/mips_malta.c | 2 +- > hw/mips/mips_r4k.c | 2 +- > hw/ppc/mac_oldworld.c | 2 +- > 3 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/hw/mips/mips_malta.c b/hw/mips/mips_malta.c > index f8d064c..23ac1ca 100644 > --- a/hw/mips/mips_malta.c > +++ b/hw/mips/mips_malta.c > @@ -954,7 +954,7 @@ void mips_malta_init(QEMUMachineInitArgs *args) > if (ram_size > (256 << 20)) { > fprintf(stderr, > "qemu: Too much memory for this machine: %d MB, maximum 256 MB\n", > - ((unsigned int)ram_size / (1 << 20))); > + (unsigned int)(ram_size / (1 << 20))); > exit(1); > } > memory_region_init_ram(ram, NULL, "mips_malta.ram", ram_size); > diff --git a/hw/mips/mips_r4k.c b/hw/mips/mips_r4k.c > index 044f232..e8108ac 100644 > --- a/hw/mips/mips_r4k.c > +++ b/hw/mips/mips_r4k.c > @@ -201,7 +201,7 @@ void mips_r4k_init(QEMUMachineInitArgs *args) > if (ram_size > (256 << 20)) { > fprintf(stderr, > "qemu: Too much memory for this machine: %d MB, maximum 256 MB\n", > - ((unsigned int)ram_size / (1 << 20))); > + (unsigned int)(ram_size / (1 << 20))); > exit(1); > } > memory_region_init_ram(ram, NULL, "mips_r4k.ram", ram_size); > diff --git a/hw/ppc/mac_oldworld.c b/hw/ppc/mac_oldworld.c > index 42bb9d5..d7d1758 100644 > --- a/hw/ppc/mac_oldworld.c > +++ b/hw/ppc/mac_oldworld.c > @@ -124,7 +124,7 @@ static void ppc_heathrow_init(QEMUMachineInitArgs *args) > if (ram_size > (2047 << 20)) { > fprintf(stderr, > "qemu: Too much memory for this machine: %d MB, maximum 2047 MB\n", > - ((unsigned int)ram_size / (1 << 20))); > + (unsigned int)(ram_size / (1 << 20))); > exit(1); > } For the MIPS part: Acked-by: Aurelien Jarno But as already said, it's probably better to wait for the Malta 2GB patch to be merged first and send it to the trivial patches queue. -- Aurelien Jarno GPG: 1024D/F1BCDB73 aurelien@aurel32.net http://www.aurel32.net