From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59539) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VEoet-0007dU-0U for qemu-devel@nongnu.org; Wed, 28 Aug 2013 18:56:19 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VEoeo-00074e-JZ for qemu-devel@nongnu.org; Wed, 28 Aug 2013 18:56:14 -0400 Received: from mx1.redhat.com ([209.132.183.28]:34234) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VEoeo-00074Y-Ch for qemu-devel@nongnu.org; Wed, 28 Aug 2013 18:56:10 -0400 Date: Wed, 28 Aug 2013 23:55:54 +0100 From: "Richard W.M. Jones" Message-ID: <20130828225553.GA732@redhat.com> References: <1377550812-908-1-git-send-email-rth@twiddle.net> <1377550812-908-8-git-send-email-rth@twiddle.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1377550812-908-8-git-send-email-rth@twiddle.net> Subject: Re: [Qemu-devel] [PULL 7/7] tcg-i386: Use new return-argument ld/st helpers List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Richard Henderson Cc: aurelien@aurel32.net, qemu-devel@nongnu.org, anthony@codemonkey.ws On Mon, Aug 26, 2013 at 02:00:12PM -0700, Richard Henderson wrote: > Discontinue the jump-around-jump-to-jump scheme, trading it for a single > immediate move instruction. The two extra jumps always consume 7 bytes, > whereas the immediate move is either 5 or 7 bytes depending on where the > code_gen_buffer gets located. This seems to have broken qemu-system-ppc64: https://bugs.launchpad.net/qemu/+bug/1218098 Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones libguestfs lets you edit virtual machines. Supports shell scripting, bindings from many languages. http://libguestfs.org