From: Stefan Hajnoczi <stefanha@gmail.com>
To: Bharata B Rao <bharata@linux.vnet.ibm.com>
Cc: kwolf@redhat.com, pbonzini@redhat.com, asias@redhat.com,
qemu-devel@nongnu.org, stefanha@redhat.com
Subject: Re: [Qemu-devel] [PATCH v1] gluster: Abort on AIO completion failure
Date: Thu, 29 Aug 2013 09:35:42 +0200 [thread overview]
Message-ID: <20130829073542.GA23096@stefanha-thinkpad.redhat.com> (raw)
In-Reply-To: <1377591341-2417-1-git-send-email-bharata@linux.vnet.ibm.com>
On Tue, Aug 27, 2013 at 01:45:41PM +0530, Bharata B Rao wrote:
> Currently if gluster AIO callback thread fails to notify the QEMU thread about
> AIO completion, we try graceful recovery by marking the disk drive as
> inaccessible. This error recovery code is race-prone as found by Asias and
> Stefan. However as found out by Paolo, this kind of error is impossible and
> hence simplify the code that handles this error recovery.
>
> Signed-off-by: Bharata B Rao <bharata@linux.vnet.ibm.com>
> ---
> Changes in v1: Print errno information.
>
>
> block/gluster.c | 15 ++-------------
> 1 file changed, 2 insertions(+), 13 deletions(-)
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
next prev parent reply other threads:[~2013-08-29 7:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-27 8:15 [Qemu-devel] [PATCH v1] gluster: Abort on AIO completion failure Bharata B Rao
2013-08-29 7:35 ` Stefan Hajnoczi [this message]
2013-08-29 7:45 ` Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130829073542.GA23096@stefanha-thinkpad.redhat.com \
--to=stefanha@gmail.com \
--cc=asias@redhat.com \
--cc=bharata@linux.vnet.ibm.com \
--cc=kwolf@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).