From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51309) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VEwlm-0005qH-M2 for qemu-devel@nongnu.org; Thu, 29 Aug 2013 03:36:03 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VEwle-000670-92 for qemu-devel@nongnu.org; Thu, 29 Aug 2013 03:35:54 -0400 Received: from mail-ee0-x22b.google.com ([2a00:1450:4013:c00::22b]:42462) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VEwle-00066w-1H for qemu-devel@nongnu.org; Thu, 29 Aug 2013 03:35:46 -0400 Received: by mail-ee0-f43.google.com with SMTP id e52so40254eek.2 for ; Thu, 29 Aug 2013 00:35:45 -0700 (PDT) Date: Thu, 29 Aug 2013 09:35:42 +0200 From: Stefan Hajnoczi Message-ID: <20130829073542.GA23096@stefanha-thinkpad.redhat.com> References: <1377591341-2417-1-git-send-email-bharata@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1377591341-2417-1-git-send-email-bharata@linux.vnet.ibm.com> Subject: Re: [Qemu-devel] [PATCH v1] gluster: Abort on AIO completion failure List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Bharata B Rao Cc: kwolf@redhat.com, pbonzini@redhat.com, asias@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com On Tue, Aug 27, 2013 at 01:45:41PM +0530, Bharata B Rao wrote: > Currently if gluster AIO callback thread fails to notify the QEMU thread about > AIO completion, we try graceful recovery by marking the disk drive as > inaccessible. This error recovery code is race-prone as found by Asias and > Stefan. However as found out by Paolo, this kind of error is impossible and > hence simplify the code that handles this error recovery. > > Signed-off-by: Bharata B Rao > --- > Changes in v1: Print errno information. > > > block/gluster.c | 15 ++------------- > 1 file changed, 2 insertions(+), 13 deletions(-) Reviewed-by: Stefan Hajnoczi