From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53425) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VEwvL-0000WB-5E for qemu-devel@nongnu.org; Thu, 29 Aug 2013 03:45:53 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VEwvF-0000KC-4N for qemu-devel@nongnu.org; Thu, 29 Aug 2013 03:45:47 -0400 Received: from mx1.redhat.com ([209.132.183.28]:64643) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VEwvE-0000J1-IK for qemu-devel@nongnu.org; Thu, 29 Aug 2013 03:45:40 -0400 Date: Thu, 29 Aug 2013 09:45:47 +0200 From: Kevin Wolf Message-ID: <20130829074547.GB2961@dhcp-200-207.str.redhat.com> References: <1377591341-2417-1-git-send-email-bharata@linux.vnet.ibm.com> <20130829073542.GA23096@stefanha-thinkpad.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20130829073542.GA23096@stefanha-thinkpad.redhat.com> Subject: Re: [Qemu-devel] [PATCH v1] gluster: Abort on AIO completion failure List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi Cc: pbonzini@redhat.com, asias@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com, Bharata B Rao Am 29.08.2013 um 09:35 hat Stefan Hajnoczi geschrieben: > On Tue, Aug 27, 2013 at 01:45:41PM +0530, Bharata B Rao wrote: > > Currently if gluster AIO callback thread fails to notify the QEMU thread about > > AIO completion, we try graceful recovery by marking the disk drive as > > inaccessible. This error recovery code is race-prone as found by Asias and > > Stefan. However as found out by Paolo, this kind of error is impossible and > > hence simplify the code that handles this error recovery. > > > > Signed-off-by: Bharata B Rao > > --- > > Changes in v1: Print errno information. > > > > > > block/gluster.c | 15 ++------------- > > 1 file changed, 2 insertions(+), 13 deletions(-) > > Reviewed-by: Stefan Hajnoczi Thanks, applied to the block branch. (Wouldn't have hurt though to mention why this kind of error is impossible and what the race is.) Kevin