From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33535) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VExVK-0003GC-Gr for qemu-devel@nongnu.org; Thu, 29 Aug 2013 04:23:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VExVD-0004BF-Hq for qemu-devel@nongnu.org; Thu, 29 Aug 2013 04:22:58 -0400 Received: from mx1.redhat.com ([209.132.183.28]:25786) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VExVD-0004Au-9h for qemu-devel@nongnu.org; Thu, 29 Aug 2013 04:22:51 -0400 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r7T8MnEh005538 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 29 Aug 2013 04:22:50 -0400 Date: Thu, 29 Aug 2013 10:23:03 +0200 From: Kevin Wolf Message-ID: <20130829082303.GC2961@dhcp-200-207.str.redhat.com> References: <1377701706-965-1-git-send-email-mreitz@redhat.com> <1377701706-965-2-git-send-email-mreitz@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1377701706-965-2-git-send-email-mreitz@redhat.com> Subject: Re: [Qemu-devel] [PATCH v2 1/5] qcow2: Add corrupt bit List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Max Reitz Cc: qemu-devel@nongnu.org, Stefan Hajnoczi Am 28.08.2013 um 16:55 hat Max Reitz geschrieben: > This adds an incompatible bit indicating corruption to qcow2. Any image > with this bit set may not be written to unless for repairing (and > subsequently clearing the bit if the repair has been successful). > > Signed-off-by: Max Reitz > --- > block/qcow2.c | 45 +++++++++++++++++++++++++++++++++++++++++++++ > block/qcow2.h | 7 ++++++- > docs/specs/qcow2.txt | 7 ++++++- > tests/qemu-iotests/031.out | 12 ++++++------ > tests/qemu-iotests/036.out | 2 +- > 5 files changed, 64 insertions(+), 9 deletions(-) > @@ -402,6 +433,15 @@ static int qcow2_open(BlockDriverState *bs, QDict *options, int flags) > goto fail; > } > > + if (s->incompatible_features & QCOW2_INCOMPAT_CORRUPT) { > + /* Corrupt images may not be written to unless they are being repaired > + */ > + if ((flags & BDRV_O_RDWR) && !(flags & BDRV_O_CHECK)) { > + ret = -EACCES; Perhaps a (q)error_report() call would be appropriate so that the user isn't confused with only the "Permission denied" message (should it be EPERM rather than EACCES, too? Or maybe EROFS?) > + goto fail; > + } > + } > + Kevin