From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37399) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VF3Qc-0006Gr-56 for qemu-devel@nongnu.org; Thu, 29 Aug 2013 10:42:36 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VF3QT-000538-0N for qemu-devel@nongnu.org; Thu, 29 Aug 2013 10:42:30 -0400 Received: from mx1.redhat.com ([209.132.183.28]:22467) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VF3QS-00052y-Nc for qemu-devel@nongnu.org; Thu, 29 Aug 2013 10:42:20 -0400 Date: Thu, 29 Aug 2013 10:16:48 -0400 From: Luiz Capitulino Message-ID: <20130829101648.7c999282@redhat.com> In-Reply-To: <1377607107-11612-1-git-send-email-xiawenc@linux.vnet.ibm.com> References: <1377607107-11612-1-git-send-email-xiawenc@linux.vnet.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH V10 00/15] monitor: support sub command group in auto completion and help List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Wenchao Xia Cc: qemu-devel@nongnu.org, armbru@redhat.com On Tue, 27 Aug 2013 20:38:12 +0800 Wenchao Xia wrote: > This series make auto completion and help functions works normal for sub > command, by using reentrant functions. In order to do that, global variables > are not directly used in those functions any more. With this series, cmd_table > is a member of structure Monitor so it is possible to create a monitor with > different command table now, auto completion will work in that monitor. In > short, "info" is not treated as a special case now, this series ensure help > and auto complete function works normal for any sub command added in the future. > > Patch 5 replaced cur_mon with rs->mon, it is safe because: > monitor_init() calls readline_init() which initialize mon->rs, result is > mon->rs->mon == mon. Then qemu_chr_add_handlers() is called, which make > monitor_read() function take *mon as its opaque. Later, when user input, > monitor_read() is called, where cur_mon is set to *mon by "cur_mon = opaque". > If qemu's monitors run in one thread, then later in readline_handle_byte() > and readline_comletion(), cur_mon is actually equal to rs->mon, in another > word, it points to the monitor instance, so it is safe to replace *cur_mon > in those functions. > > Thanks for Luiz and Eric for reviewing. Applied to the qmp branch, thanks. Btw, I'm assuming that the patches that contain Eric's reviewed-by didn't change since he reviewed them. Personally, I don't think it's right to carry reviewed-bys when the patch changes, even if it's something small or obvious.