From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35124) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VEzrD-0001vs-LM for qemu-devel@nongnu.org; Thu, 29 Aug 2013 06:53:48 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VEzr8-0002vH-Rs for qemu-devel@nongnu.org; Thu, 29 Aug 2013 06:53:43 -0400 Received: from hall.aurel32.net ([2001:470:1f0b:4a8::1]:37960) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VEzr8-0002uq-L6 for qemu-devel@nongnu.org; Thu, 29 Aug 2013 06:53:38 -0400 Date: Thu, 29 Aug 2013 12:53:31 +0200 From: Aurelien Jarno Message-ID: <20130829105331.GI5908@ohm.aurel32.net> References: <1377190729-14008-1-git-send-email-rth@twiddle.net> <1377190729-14008-6-git-send-email-rth@twiddle.net> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline In-Reply-To: <1377190729-14008-6-git-send-email-rth@twiddle.net> Subject: Re: [Qemu-devel] [PATCH 05/18] tcg: Define TCG_TYPE_PTR properly List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Richard Henderson Cc: qemu-devel@nongnu.org On Thu, Aug 22, 2013 at 09:58:36AM -0700, Richard Henderson wrote: > Signed-off-by: Richard Henderson > --- > tcg/tcg.h | 9 ++++++--- > 1 file changed, 6 insertions(+), 3 deletions(-) > > diff --git a/tcg/tcg.h b/tcg/tcg.h > index bfe420a..b71dcf4 100644 > --- a/tcg/tcg.h > +++ b/tcg/tcg.h > @@ -173,9 +173,12 @@ typedef enum TCGType { > TCG_TYPE_REG = TCG_TYPE_I64, > #endif > > - /* An alias for the size of the native pointer. We don't currently > - support any hosts with 64-bit registers and 32-bit pointers. */ > - TCG_TYPE_PTR = TCG_TYPE_REG, > + /* An alias for the size of the native pointer. */ > +#if UINTPTR_MAX == UINT32_MAX > + TCG_TYPE_PTR = TCG_TYPE_I32, > +#else > + TCG_TYPE_PTR = TCG_TYPE_I64, > +#endif > > /* An alias for the size of the target "long", aka register. */ > #if TARGET_LONG_BITS == 64 Reviewed-by: Aurelien Jarno -- Aurelien Jarno GPG: 1024D/F1BCDB73 aurelien@aurel32.net http://www.aurel32.net