Re: [Qemu-devel] [PATCH 10/18] tcg: Use uintptr_t in TCGHelperInfo

[Aurelien Jarno <aurelien@aurel32.net>]

On Thu, Aug 22, 2013 at 09:58:41AM -0700, Richard Henderson wrote:
> Signed-off-by: Richard Henderson <rth@twiddle.net>
> ---
>  tcg/tcg.c | 6 +++---
>  tcg/tcg.h | 2 +-
>  2 files changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/tcg/tcg.c b/tcg/tcg.c
> index c6ab07f..c80aa3c 100644
> --- a/tcg/tcg.c
> +++ b/tcg/tcg.c
> @@ -625,7 +625,7 @@ void tcg_register_helper(void *func, const char *name)
>          s->helpers = realloc(s->helpers, n * sizeof(TCGHelperInfo));
>          s->allocated_helpers = n;
>      }
> -    s->helpers[s->nb_helpers].func = (tcg_target_ulong)func;
> +    s->helpers[s->nb_helpers].func = (uintptr_t)func;
>      s->helpers[s->nb_helpers].name = name;
>      s->nb_helpers++;
>  }
> @@ -855,11 +855,11 @@ static int helper_cmp(const void *p1, const void *p2)
>  }
>  
>  /* find helper definition (Note: A hash table would be better) */
> -static TCGHelperInfo *tcg_find_helper(TCGContext *s, tcg_target_ulong val)
> +static TCGHelperInfo *tcg_find_helper(TCGContext *s, uintptr_t val)
>  {
>      int m, m_min, m_max;
>      TCGHelperInfo *th;
> -    tcg_target_ulong v;
> +    uintptr_t v;
>  
>      if (unlikely(!s->helpers_sorted)) {
>          qsort(s->helpers, s->nb_helpers, sizeof(TCGHelperInfo), 
> diff --git a/tcg/tcg.h b/tcg/tcg.h
> index 2375dc4..6e2d619 100644
> --- a/tcg/tcg.h
> +++ b/tcg/tcg.h
> @@ -397,7 +397,7 @@ typedef struct TCGTemp {
>  } TCGTemp;
>  
>  typedef struct TCGHelperInfo {
> -    tcg_target_ulong func;
> +    uintptr_t func;
>      const char *name;
>  } TCGHelperInfo;
>  
> -- 
> 1.8.1.4
> 
> 
> 

Reviewed-by: Aurelien Jarno <aurelien@aurel32.net>

-- 
Aurelien Jarno                          GPG: 1024D/F1BCDB73
aurelien@aurel32.net                 http://www.aurel32.net