From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52531) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VF4CJ-0000Vi-8h for qemu-devel@nongnu.org; Thu, 29 Aug 2013 11:31:55 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VF4CA-0005Yw-Si for qemu-devel@nongnu.org; Thu, 29 Aug 2013 11:31:47 -0400 Received: from mail-ea0-x233.google.com ([2a00:1450:4013:c01::233]:40108) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VF4CA-0005Yo-Ex for qemu-devel@nongnu.org; Thu, 29 Aug 2013 11:31:38 -0400 Received: by mail-ea0-f179.google.com with SMTP id b10so327441eae.38 for ; Thu, 29 Aug 2013 08:31:37 -0700 (PDT) Date: Thu, 29 Aug 2013 17:31:35 +0200 From: Stefan Hajnoczi Message-ID: <20130829153135.GE17744@stefanha-thinkpad.redhat.com> References: <1376070245-22557-1-git-send-email-charlie@ctshepherd.com> <1376070245-22557-8-git-send-email-charlie@ctshepherd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1376070245-22557-8-git-send-email-charlie@ctshepherd.com> Subject: Re: [Qemu-devel] [RFC v2 08/15] Convert bdrv_create and associated functions to be coroutine_fn List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Charlie Shepherd Cc: kwolf@redhat.com, pbonzini@redhat.com, gabriel@kerneis.info, qemu-devel@nongnu.org On Fri, Aug 09, 2013 at 07:43:58PM +0200, Charlie Shepherd wrote: > This patch converts bdrv_create, bdrv_create_file and bdrv_img_create to be > coroutine only functions. It adds a synchronous wrapper, bdrv_sync_create, for > any synchronous callers. It would be more consistent to call the coroutine_fn bdrv_co_create() and the synchronous function bdrv_create(). We don't have the bdrv_sync_foo() naming convention and it's easily confused with the bdrv_pwrite_sync() function which flushes the disk cache (fsync(2)).