From: "Richard W.M. Jones" <rjones@redhat.com>
To: Richard Henderson <rth@twiddle.net>
Cc: anthony@codemonkey.ws, qemu-devel@nongnu.org, aurelien@aurel32.net
Subject: Re: [Qemu-devel] [PATCH] tcg-i386: Remove abort from GETPC_LDST
Date: Thu, 29 Aug 2013 16:50:43 +0100 [thread overview]
Message-ID: <20130829155042.GF5918@redhat.com> (raw)
In-Reply-To: <1377789697-12561-1-git-send-email-rth@twiddle.net>
On Thu, Aug 29, 2013 at 08:21:37AM -0700, Richard Henderson wrote:
> Indeed, remove it entirely and remove the is_tcg_gen_code check
> from GETPC_EXT.
>
> Fixes https://bugs.launchpad.net/qemu/+bug/1218098 wherein a call
> to a "normal" helper function performed a sequence of tail calls
> all the way into the memory helper functions, leading to a stack
> frame in which the memory helper function appeared to be called
> directly from tcg.
>
> Signed-off-by: Richard Henderson <rth@twiddle.net>
This fixes the bug I saw.
Tested-by: Richard W.M. Jones <rjones@redhat.com>
Rich.
--
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming blog: http://rwmj.wordpress.com
Fedora now supports 80 OCaml packages (the OPEN alternative to F#)
next prev parent reply other threads:[~2013-08-29 15:51 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-26 21:00 [Qemu-devel] [PULL 0/7] Improve tcg ldst optimization Richard Henderson
2013-08-26 21:00 ` [Qemu-devel] [PULL 1/7] tcg: Tidy generated code for tcg_outN Richard Henderson
2013-08-26 21:00 ` [Qemu-devel] [PULL 2/7] tcg-i386: Add and use tcg_out64 Richard Henderson
2013-08-26 21:00 ` [Qemu-devel] [PULL 3/7] tcg-i386: Try pc-relative lea for constant formation Richard Henderson
2013-08-26 21:00 ` [Qemu-devel] [PULL 4/7] tcg-i386: Tidy qemu_ld/st slow path Richard Henderson
2013-08-26 21:00 ` [Qemu-devel] [PULL 5/7] tcg: Add mmu helpers that take a return address argument Richard Henderson
2013-08-26 22:26 ` Paolo Bonzini
2013-08-26 22:34 ` Richard Henderson
2013-08-27 10:46 ` Aurelien Jarno
2013-08-27 14:53 ` Richard Henderson
2013-08-27 15:43 ` Aurelien Jarno
2013-08-27 15:53 ` Richard Henderson
2013-08-26 23:26 ` Peter Maydell
2013-08-27 10:47 ` Aurelien Jarno
2013-08-26 21:00 ` [Qemu-devel] [PULL 6/7] tcg: Tidy softmmu_template.h Richard Henderson
2013-08-26 21:00 ` [Qemu-devel] [PULL 7/7] tcg-i386: Use new return-argument ld/st helpers Richard Henderson
2013-08-28 22:55 ` Richard W.M. Jones
2013-08-29 15:21 ` [Qemu-devel] [PATCH] tcg-i386: Remove abort from GETPC_LDST Richard Henderson
2013-08-29 15:28 ` Paolo Bonzini
2013-08-29 15:32 ` Richard Henderson
2013-08-29 15:50 ` Richard W.M. Jones [this message]
2013-08-29 19:13 ` Aurelien Jarno
2013-08-27 21:30 ` [Qemu-devel] [PULL 0/7] Improve tcg ldst optimization Aurelien Jarno
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130829155042.GF5918@redhat.com \
--to=rjones@redhat.com \
--cc=anthony@codemonkey.ws \
--cc=aurelien@aurel32.net \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).