From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60106) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VF4Uv-0002cG-Q6 for qemu-devel@nongnu.org; Thu, 29 Aug 2013 11:51:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VF4Ur-0004hE-9P for qemu-devel@nongnu.org; Thu, 29 Aug 2013 11:51:01 -0400 Received: from mx1.redhat.com ([209.132.183.28]:61080) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VF4Ur-0004gv-1u for qemu-devel@nongnu.org; Thu, 29 Aug 2013 11:50:57 -0400 Date: Thu, 29 Aug 2013 16:50:43 +0100 From: "Richard W.M. Jones" Message-ID: <20130829155042.GF5918@redhat.com> References: <20130828225553.GA732@redhat.com> <1377789697-12561-1-git-send-email-rth@twiddle.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1377789697-12561-1-git-send-email-rth@twiddle.net> Subject: Re: [Qemu-devel] [PATCH] tcg-i386: Remove abort from GETPC_LDST List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Richard Henderson Cc: anthony@codemonkey.ws, qemu-devel@nongnu.org, aurelien@aurel32.net On Thu, Aug 29, 2013 at 08:21:37AM -0700, Richard Henderson wrote: > Indeed, remove it entirely and remove the is_tcg_gen_code check > from GETPC_EXT. > > Fixes https://bugs.launchpad.net/qemu/+bug/1218098 wherein a call > to a "normal" helper function performed a sequence of tail calls > all the way into the memory helper functions, leading to a stack > frame in which the memory helper function appeared to be called > directly from tcg. > > Signed-off-by: Richard Henderson This fixes the bug I saw. Tested-by: Richard W.M. Jones Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming blog: http://rwmj.wordpress.com Fedora now supports 80 OCaml packages (the OPEN alternative to F#)