From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:39297)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <antonynpavlov@gmail.com>) id 1VF523-00079X-NS
	for qemu-devel@nongnu.org; Thu, 29 Aug 2013 12:25:24 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <antonynpavlov@gmail.com>) id 1VF51v-0007VM-9T
	for qemu-devel@nongnu.org; Thu, 29 Aug 2013 12:25:15 -0400
Received: from mail-lb0-x22b.google.com ([2a00:1450:4010:c04::22b]:58444)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <antonynpavlov@gmail.com>) id 1VF51v-0007Us-1G
	for qemu-devel@nongnu.org; Thu, 29 Aug 2013 12:25:07 -0400
Received: by mail-lb0-f171.google.com with SMTP id u14so898163lbd.2
	for <qemu-devel@nongnu.org>; Thu, 29 Aug 2013 09:25:06 -0700 (PDT)
Date: Thu, 29 Aug 2013 20:22:42 +0400
From: Antony Pavlov <antonynpavlov@gmail.com>
Message-Id: <20130829202242.2b40e280add3b150eefeb9ce@gmail.com>
In-Reply-To: <CANyvUMASe9icBkmDk_U0kRF0+2PO-DkJZRaOBEYuZOTJM4TzJQ@mail.gmail.com>
References: <1377768833-11400-1-git-send-email-antonynpavlov@gmail.com>
	<1377768833-11400-3-git-send-email-antonynpavlov@gmail.com>
	<CANyvUMASe9icBkmDk_U0kRF0+2PO-DkJZRaOBEYuZOTJM4TzJQ@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [RFC 2/5] hw/arm: add very initial support for
	Canon DIGIC SoC
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Condello <condellog@gmail.com>
Cc: Alex Dumitrache <broscutamaker@gmail.com>, Peter Crosthwaite <peter.crosthwaite@xilinx.com>, g3gg0 <georg.hofstetter@lx-networking.de>, Peter Maydell <peter.maydell@linaro.org>, qemu-devel@nongnu.org, Paul Brook <paul@codesourcery.com>, Paolo Bonzini <pbonzini@redhat.com>

On Thu, 29 Aug 2013 16:29:30 +0200
Condello <condellog@gmail.com> wrote:

> On Thu, Aug 29, 2013 at 11:33 AM, Antony Pavlov <antonynpavlov@gmail.com>=
 wrote:
> > diff --git a/default-configs/arm-softmmu.mak b/default-configs/arm-soft=
mmu.mak
> > index ac0815d..0d1d783 100644
> > --- a/default-configs/arm-softmmu.mak
> > +++ b/default-configs/arm-softmmu.mak
> > @@ -63,6 +63,7 @@ CONFIG_FRAMEBUFFER=3Dy
> >  CONFIG_XILINX_SPIPS=3Dy
> >
> >  CONFIG_A9SCU=3Dy
> > +CONFIG_DIGIC=3Dy
>=20
> IMHO CONFIG_DIGIC should really be CONFIG_DIGIC_4. We don't know how
> the DIGIC package will change in the future but it doesn't hurt since
> everything else references digic4 already.

There are two reasons to use CONFIG_DIGIC, but not CONFIG_DIGIC4:

1. CONFIG_DIGIC is used not only for SoC support enabling but for IP-block =
(UART and TIMER) enabling too. But this blocks are used not only in DIGIC4,=
 so if you use
CONFIG_DIGIC4 for SoC enabling you need use something like CONFIG_DIGIC_UAR=
T and
CONFIG_DIGIC_TIMER for IP-block enabling. But if you enable your CONFIG_DIG=
IC4
but CONFIG_DIGIC_UART is disabled then qemu fails to start digic board
(I unintentionally checked this fact yesterday :).
Does we really need this overcomplication?

Just now it is not evident how to make the partition of the code.

2. AFAIR the digic chips are different but the core functionality is the sa=
me.
I have red in CHDK forum about a programm for DIGIC3 that run well on DIGIC=
4.

--=A0
Best regards,
=A0 Antony Pavlov