From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49747) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VFMwo-0002Nk-DP for qemu-devel@nongnu.org; Fri, 30 Aug 2013 07:33:08 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VFMwi-0003D8-8C for qemu-devel@nongnu.org; Fri, 30 Aug 2013 07:33:02 -0400 Received: from mx1.redhat.com ([209.132.183.28]:25754) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VFMwi-0003Cv-0S for qemu-devel@nongnu.org; Fri, 30 Aug 2013 07:32:56 -0400 Date: Fri, 30 Aug 2013 07:31:51 -0400 From: Luiz Capitulino Message-ID: <20130830073151.5190f3ff@redhat.com> In-Reply-To: <522001F3.8080706@linux.vnet.ibm.com> References: <1377607107-11612-1-git-send-email-xiawenc@linux.vnet.ibm.com> <20130829101648.7c999282@redhat.com> <522001F3.8080706@linux.vnet.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH V10 00/15] monitor: support sub command group in auto completion and help List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Wenchao Xia Cc: qemu-devel@nongnu.org, armbru@redhat.com On Fri, 30 Aug 2013 10:22:43 +0800 Wenchao Xia wrote: > =E4=BA=8E 2013-8-29 22:16, Luiz Capitulino =E5=86=99=E9=81=93: > > On Tue, 27 Aug 2013 20:38:12 +0800 > > Wenchao Xia wrote: > > > >> This series make auto completion and help functions works normal for s= ub > >> command, by using reentrant functions. In order to do that, global var= iables > >> are not directly used in those functions any more. With this series, c= md_table > >> is a member of structure Monitor so it is possible to create a monitor= with > >> different command table now, auto completion will work in that monitor= . In > >> short, "info" is not treated as a special case now, this series ensure= help > >> and auto complete function works normal for any sub command added in t= he future. > >> > >> Patch 5 replaced cur_mon with rs->mon, it is safe because: > >> monitor_init() calls readline_init() which initialize mon->rs, result = is > >> mon->rs->mon =3D=3D mon. Then qemu_chr_add_handlers() is called, which= make > >> monitor_read() function take *mon as its opaque. Later, when user inpu= t, > >> monitor_read() is called, where cur_mon is set to *mon by "cur_mon =3D= opaque". > >> If qemu's monitors run in one thread, then later in readline_handle_by= te() > >> and readline_comletion(), cur_mon is actually equal to rs->mon, in ano= ther > >> word, it points to the monitor instance, so it is safe to replace *cur= _mon > >> in those functions. > >> > >> Thanks for Luiz and Eric for reviewing. > > > > Applied to the qmp branch, thanks. > > > > Btw, I'm assuming that the patches that contain Eric's reviewed-by didn= 't > > change since he reviewed them. Personally, I don't think it's right to = carry > > reviewed-bys when the patch changes, even if it's something small or > > obvious. > > > I remember that the "Reviewed-by" were removed on all changed > patches, except: > Patches of V7 have typo issues which were pointed > out by Eric with "Reviewed-by", for those I fixed the typo and kept the > "Reviewed by". > Some patches were not modified but the line number may change, > since previous patch may have inserted new lines. For those I didn't > remove "Reviewed-by". > If the above is not appropriate, I'll avoid it. Looks fine to me.