From: Kevin Wolf <kwolf@redhat.com>
To: Max Reitz <mreitz@redhat.com>
Cc: qemu-devel@nongnu.org, Stefan Hajnoczi <stefanha@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v3 0/8] Add metadata overlap checks
Date: Fri, 30 Aug 2013 11:02:49 +0200 [thread overview]
Message-ID: <20130830090249.GB2840@dhcp-200-207.str.redhat.com> (raw)
In-Reply-To: <1377848818-2623-1-git-send-email-mreitz@redhat.com>
Am 30.08.2013 um 09:46 hat Max Reitz geschrieben:
> If a qcow2 image file becomes corrupted, any write may inadvertently
> overwrite important metadata structures such as the L1 table. This
> series adds functionality for detecting, preventing and (to some extent)
> repairing such collisions.
>
> v3:
> - split PATCH 4/5 into four distinct patches (4/8, 5/8, 6/8 and 7/8,
> respectively)
> - directly generate a JSON message when marking the image corrupt
> - other (minor) fixes according to Kevin's comments
>
> v2:
> - Generally implemented Kevin's comments, especially:
> - new QMP event QEVENT_BLOCK_IMAGE_CORRUPTED
> - removed BDRV_O_REPAIR in favor of BDRV_O_CHECK | BDRV_O_RDWR
> - always check full clusters for overlaps
> - removed qcow2_check_allocations in favor of some
> qcow2_check_refcounts extensions that will hopefully include all
> that functionality
Commented on patch 4, the others are:
Reviewed-by: Kevin Wolf <kwolf@redhat.com>
prev parent reply other threads:[~2013-08-30 9:03 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-30 7:46 [Qemu-devel] [PATCH v3 0/8] Add metadata overlap checks Max Reitz
2013-08-30 7:46 ` [Qemu-devel] [PATCH v3 1/8] qcow2: Add corrupt bit Max Reitz
2013-08-30 7:46 ` [Qemu-devel] [PATCH v3 2/8] qcow2: Metadata overlap checks Max Reitz
2013-08-30 7:46 ` [Qemu-devel] [PATCH v3 3/8] qcow2: Employ metadata " Max Reitz
2013-08-30 7:46 ` [Qemu-devel] [PATCH v3 4/8] qcow2-refcount: Move OFLAG_COPIED checks Max Reitz
2013-08-30 8:48 ` Kevin Wolf
2013-08-30 9:39 ` Max Reitz
2013-08-30 7:46 ` [Qemu-devel] [PATCH v3 5/8] qcow2-refcount: Repair OFLAG_COPIED errors Max Reitz
2013-08-30 7:46 ` [Qemu-devel] [PATCH v3 6/8] qcow2-refcount: Repair shared refcount blocks Max Reitz
2013-08-30 7:46 ` [Qemu-devel] [PATCH v3 7/8] qcow2_check: Mark image consistent Max Reitz
2013-08-30 7:46 ` [Qemu-devel] [PATCH v3 8/8] qemu-iotests: Overlapping cluster allocations Max Reitz
2013-08-30 9:02 ` Kevin Wolf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130830090249.GB2840@dhcp-200-207.str.redhat.com \
--to=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).