* [Qemu-devel] [PATCH] virtio-rng: add check of period
@ 2013-08-30 8:35 Amos Kong
2013-08-30 9:34 ` Amit Shah
0 siblings, 1 reply; 2+ messages in thread
From: Amos Kong @ 2013-08-30 8:35 UTC (permalink / raw)
To: qemu-devel; +Cc: amit.shah
If period is assigned to 0, limit timer will expire immediately.
This limit is meaningless. This patch forbids to assign 0 to
period.
Signed-off-by: Amos Kong <akong@redhat.com>
---
hw/virtio/virtio-rng.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/hw/virtio/virtio-rng.c b/hw/virtio/virtio-rng.c
index 314e393..b22ccf1 100644
--- a/hw/virtio/virtio-rng.c
+++ b/hw/virtio/virtio-rng.c
@@ -139,6 +139,12 @@ static int virtio_rng_device_init(VirtIODevice *vdev)
VirtIORNG *vrng = VIRTIO_RNG(vdev);
Error *local_err = NULL;
+ if (!vrng->conf.period_ms > 0) {
+ qerror_report(QERR_INVALID_PARAMETER_VALUE, "period",
+ "a positive number");
+ return -1;
+ }
+
if (vrng->conf.rng == NULL) {
vrng->conf.default_backend = RNG_RANDOM(object_new(TYPE_RNG_RANDOM));
--
1.8.3.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [Qemu-devel] [PATCH] virtio-rng: add check of period
2013-08-30 8:35 [Qemu-devel] [PATCH] virtio-rng: add check of period Amos Kong
@ 2013-08-30 9:34 ` Amit Shah
0 siblings, 0 replies; 2+ messages in thread
From: Amit Shah @ 2013-08-30 9:34 UTC (permalink / raw)
To: Amos Kong; +Cc: qemu-devel
On (Fri) 30 Aug 2013 [16:35:51], Amos Kong wrote:
> If period is assigned to 0, limit timer will expire immediately.
> This limit is meaningless. This patch forbids to assign 0 to
> period.
>
> Signed-off-by: Amos Kong <akong@redhat.com>
Reviewed-by: Amit Shah <amit.shah@redhat.com>
Amit
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-08-30 9:34 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-08-30 8:35 [Qemu-devel] [PATCH] virtio-rng: add check of period Amos Kong
2013-08-30 9:34 ` Amit Shah
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).