From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:57806)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <aurelien@aurel32.net>) id 1VFRz0-0004Gq-35
	for qemu-devel@nongnu.org; Fri, 30 Aug 2013 12:55:42 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <aurelien@aurel32.net>) id 1VFRyv-00067O-4X
	for qemu-devel@nongnu.org; Fri, 30 Aug 2013 12:55:38 -0400
Received: from hall.aurel32.net ([2001:470:1f0b:4a8::1]:45228)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <aurelien@aurel32.net>) id 1VFRyu-00063H-Te
	for qemu-devel@nongnu.org; Fri, 30 Aug 2013 12:55:33 -0400
Date: Fri, 30 Aug 2013 18:55:16 +0200
From: Aurelien Jarno <aurelien@aurel32.net>
Message-ID: <20130830165516.GA15581@ohm.aurel32.net>
References: <1377813961-12208-1-git-send-email-rth@twiddle.net>
	<1377813961-12208-4-git-send-email-rth@twiddle.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-15
Content-Disposition: inline
In-Reply-To: <1377813961-12208-4-git-send-email-rth@twiddle.net>
Subject: Re: [Qemu-devel] [PATCH v2 3/7] exec: Rename USUFFIX to LSUFFIX
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Richard Henderson <rth@twiddle.net>
Cc: qemu-devel@nongnu.org

On Thu, Aug 29, 2013 at 03:05:57PM -0700, Richard Henderson wrote:
> In a following patch, there will be confusion between multiple "unsigned"
> suffixes; rename this one so as to imply "load".
> 
> Signed-off-by: Richard Henderson <rth@twiddle.net>
> ---
>  include/exec/softmmu_template.h | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/include/exec/softmmu_template.h b/include/exec/softmmu_template.h
> index 2fc6ea3..f9922e2 100644
> --- a/include/exec/softmmu_template.h
> +++ b/include/exec/softmmu_template.h
> @@ -28,19 +28,19 @@
>  
>  #if DATA_SIZE == 8
>  #define SUFFIX q
> -#define USUFFIX q
> +#define LSUFFIX q
>  #define DATA_TYPE uint64_t
>  #elif DATA_SIZE == 4
>  #define SUFFIX l
> -#define USUFFIX l
> +#define LSUFFIX l
>  #define DATA_TYPE uint32_t
>  #elif DATA_SIZE == 2
>  #define SUFFIX w
> -#define USUFFIX uw
> +#define LSUFFIX uw
>  #define DATA_TYPE uint16_t
>  #elif DATA_SIZE == 1
>  #define SUFFIX b
> -#define USUFFIX ub
> +#define LSUFFIX ub
>  #define DATA_TYPE uint8_t
>  #else
>  #error unsupported data size
> @@ -147,7 +147,7 @@ glue(glue(helper_ret_ld, SUFFIX), MMUSUFFIX)(CPUArchState *env,
>  #endif
>  
>      haddr = addr + env->tlb_table[mmu_idx][index].addend;
> -    return glue(glue(ld, USUFFIX), _raw)((uint8_t *)haddr);
> +    return glue(glue(ld, LSUFFIX), _raw)((uint8_t *)haddr);
>  }
>  
>  DATA_TYPE
> @@ -264,6 +264,6 @@ glue(glue(helper_st, SUFFIX), MMUSUFFIX)(CPUArchState *env, target_ulong addr,
>  #undef SHIFT
>  #undef DATA_TYPE
>  #undef SUFFIX
> -#undef USUFFIX
> +#undef LSUFFIX
>  #undef DATA_SIZE
>  #undef ADDR_READ

Reviewed-by: Aurelien Jarno <aurelien@aurel32.net>

-- 
Aurelien Jarno                          GPG: 1024D/F1BCDB73
aurelien@aurel32.net                 http://www.aurel32.net