qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Benoît Canet" <benoit.canet@irqsave.net>
To: Eric Blake <eblake@redhat.com>
Cc: qemu-trivial@nongnu.org, qemu-devel@nongnu.org, lcapitulino@redhat.com
Subject: Re: [Qemu-devel] [PATCH] qmp: fix integer usage in examples
Date: Fri, 30 Aug 2013 22:14:57 +0200	[thread overview]
Message-ID: <20130830201457.GB5170@irqsave.net> (raw)
In-Reply-To: <1377891353-10682-1-git-send-email-eblake@redhat.com>

Le Friday 30 Aug 2013 à 13:35:53 (-0600), Eric Blake a écrit :
> * qmp-commands.hx (block_set_io_throttle): Use correct type.
> 
> Signed-off-by: Eric Blake <eblake@redhat.com>
> ---
> 
> Noticed while reviewing Benoît's series of "Continuous Leaky Bucket
> Throttling" - depending on whose patch goes in first, the other
> will have to rebase...
> 
>  qmp-commands.hx | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/qmp-commands.hx b/qmp-commands.hx
> index bb09e72..87cfdce 100644
> --- a/qmp-commands.hx
> +++ b/qmp-commands.hx
> @@ -1412,12 +1412,12 @@ Arguments:
>  Example:
> 
>  -> { "execute": "block_set_io_throttle", "arguments": { "device": "virtio0",
> -                                               "bps": "1000000",
> -                                               "bps_rd": "0",
> -                                               "bps_wr": "0",
> -                                               "iops": "0",
> -                                               "iops_rd": "0",
> -                                               "iops_wr": "0" } }
> +                                               "bps": 1000000,
> +                                               "bps_rd": 0,
> +                                               "bps_wr": 0,
> +                                               "iops": 0,
> +                                               "iops_rd": 0,
> +                                               "iops_wr": 0 } }
>  <- { "return": {} }
> 
>  EQMP
> -- 
> 1.8.3.1
> 

I rebased my series on top of Eric patch.

Best regards

Benoît

      reply	other threads:[~2013-08-30 20:14 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-30 19:35 [Qemu-devel] [PATCH] qmp: fix integer usage in examples Eric Blake
2013-08-30 20:14 ` Benoît Canet [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130830201457.GB5170@irqsave.net \
    --to=benoit.canet@irqsave.net \
    --cc=eblake@redhat.com \
    --cc=lcapitulino@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).