From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:39733)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <benoit.canet@irqsave.net>) id 1VFV5R-000302-SI
	for qemu-devel@nongnu.org; Fri, 30 Aug 2013 16:14:35 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <benoit.canet@irqsave.net>) id 1VFV5L-0006Tx-1D
	for qemu-devel@nongnu.org; Fri, 30 Aug 2013 16:14:29 -0400
Date: Fri, 30 Aug 2013 22:14:57 +0200
From: =?iso-8859-1?Q?Beno=EEt?= Canet <benoit.canet@irqsave.net>
Message-ID: <20130830201457.GB5170@irqsave.net>
References: <1377891353-10682-1-git-send-email-eblake@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
In-Reply-To: <1377891353-10682-1-git-send-email-eblake@redhat.com>
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH] qmp: fix integer usage in examples
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Eric Blake <eblake@redhat.com>
Cc: qemu-trivial@nongnu.org, qemu-devel@nongnu.org, lcapitulino@redhat.com

Le Friday 30 Aug 2013 =E0 13:35:53 (-0600), Eric Blake a =E9crit :
> * qmp-commands.hx (block_set_io_throttle): Use correct type.
>=20
> Signed-off-by: Eric Blake <eblake@redhat.com>
> ---
>=20
> Noticed while reviewing Beno=EEt's series of "Continuous Leaky Bucket
> Throttling" - depending on whose patch goes in first, the other
> will have to rebase...
>=20
>  qmp-commands.hx | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)
>=20
> diff --git a/qmp-commands.hx b/qmp-commands.hx
> index bb09e72..87cfdce 100644
> --- a/qmp-commands.hx
> +++ b/qmp-commands.hx
> @@ -1412,12 +1412,12 @@ Arguments:
>  Example:
>=20
>  -> { "execute": "block_set_io_throttle", "arguments": { "device": "vir=
tio0",
> -                                               "bps": "1000000",
> -                                               "bps_rd": "0",
> -                                               "bps_wr": "0",
> -                                               "iops": "0",
> -                                               "iops_rd": "0",
> -                                               "iops_wr": "0" } }
> +                                               "bps": 1000000,
> +                                               "bps_rd": 0,
> +                                               "bps_wr": 0,
> +                                               "iops": 0,
> +                                               "iops_rd": 0,
> +                                               "iops_wr": 0 } }
>  <- { "return": {} }
>=20
>  EQMP
> --=20
> 1.8.3.1
>=20

I rebased my series on top of Eric patch.

Best regards

Beno=EEt