From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:43864)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <benoit.canet@irqsave.net>) id 1VFVQ0-0008Lz-91
	for qemu-devel@nongnu.org; Fri, 30 Aug 2013 16:35:49 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <benoit.canet@irqsave.net>) id 1VFVPt-0005CX-MF
	for qemu-devel@nongnu.org; Fri, 30 Aug 2013 16:35:44 -0400
Received: from nodalink.pck.nerim.net ([62.212.105.220]:58076
	helo=paradis.irqsave.net) by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <benoit.canet@irqsave.net>) id 1VFVPt-0005C7-BW
	for qemu-devel@nongnu.org; Fri, 30 Aug 2013 16:35:37 -0400
Date: Fri, 30 Aug 2013 22:37:35 +0200
From: =?iso-8859-1?Q?Beno=EEt?= Canet <benoit.canet@irqsave.net>
Message-ID: <20130830203735.GC5170@irqsave.net>
References: <1377873389-9712-1-git-send-email-benoit@irqsave.net>
	<1377873389-9712-5-git-send-email-benoit@irqsave.net>
	<5220FED4.6040801@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
In-Reply-To: <5220FED4.6040801@redhat.com>
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH V8 4/5] block: Add support for throttling
 burst max in QMP and the command line.
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Eric Blake <eblake@redhat.com>
Cc: kwolf@redhat.com, stefanha@gmail.com, qemu-devel@nongnu.org, stefanha@redhat.com, pbonzini@redhat.com

> > @@ -1404,10 +1404,16 @@ Arguments:
> >  - "device": device name (json-string)
> >  - "bps":  total throughput limit in bytes per second(json-int)
> >  - "bps_rd":  read throughput limit in bytes per second(json-int)
> > -- "bps_wr":  read throughput limit in bytes per second(json-int)
> > +- "bps_wr":  write throughput limit in bytes per second (json-int)

I though that fixing coding style related issues in lines non directly im=
pacted by a
patch was bad so I changed only this one. The funny thing is that it prop=
agate
the scope of the patch.

> It's odd that you are fixing one pre-existing case of missing space, bu=
t
> not all of them.  Should we split the cleanups into a separate patch?  =
I
> already started some cleanups[1], but could respin my patch to cover
> more, if desired.
>=20
> > @@ -1417,7 +1423,13 @@ Example:
> >                                                 "bps_wr": "0",
> >                                                 "iops": "0",
> >                                                 "iops_rd": "0",
> > -                                               "iops_wr": "0" } }
> > +                                               "iops_wr": "0",
>=20
> Depending on whether my patch[1] goes in first, fix this to use '0'
> instead of '"0"'.
>=20
> [1] still waiting for it to hit
> https://lists.gnu.org/archive/html/qemu-devel/2013-08/threads.html, but
> message id <1377891353-10682-1-git-send-email-eblake@redhat.com> [PATCH=
]
> qmp: fix integer usage in examples
I rebased on top of it.

Best regards

Beno=EEt