From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:51077)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <antonynpavlov@gmail.com>) id 1VGCQ2-0007jO-D2
	for qemu-devel@nongnu.org; Sun, 01 Sep 2013 14:30:42 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <antonynpavlov@gmail.com>) id 1VGCPw-0005T1-7a
	for qemu-devel@nongnu.org; Sun, 01 Sep 2013 14:30:38 -0400
Received: from mail-la0-x22b.google.com ([2a00:1450:4010:c03::22b]:36840)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <antonynpavlov@gmail.com>) id 1VGCPv-0005Sk-Mw
	for qemu-devel@nongnu.org; Sun, 01 Sep 2013 14:30:32 -0400
Received: by mail-la0-f43.google.com with SMTP id ep20so3008549lab.30
	for <qemu-devel@nongnu.org>; Sun, 01 Sep 2013 11:30:30 -0700 (PDT)
Date: Sun, 1 Sep 2013 22:28:06 +0400
From: Antony Pavlov <antonynpavlov@gmail.com>
Message-Id: <20130901222806.61dabd55adab6f0e75e452f8@gmail.com>
In-Reply-To: <52223F60.4000704@suse.de>
References: <1377969760-17489-1-git-send-email-antonynpavlov@gmail.com>
	<1377969760-17489-3-git-send-email-antonynpavlov@gmail.com>
	<52223F60.4000704@suse.de>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH v2 2/2] milkymist-uart: use Device::realize
 instead of SysBusDevice::init
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Andreas =?ISO-8859-1?Q?F=E4rber?= <afaerber@suse.de>
Cc: Peter Crosthwaite <peter.crosthwaite@xilinx.com>, Michael Walle <michael@walle.cc>, qemu-devel@nongnu.org

On Sat, 31 Aug 2013 21:09:20 +0200
Andreas F=E4rber <afaerber@suse.de> wrote:

> Am 31.08.2013 19:22, schrieb Antony Pavlov:
> > Use of SysBusDevice::init is deprecated.
> > Use Device::realize instead of SysBusDevice::init.
> > Check dma/pl330.c for an example of the pattern.
> >=20
> > Also introduce TypeInfo::instance_init milkymist_uart_init()
> > as char/pl011.c does.
> >=20
> > Reported-by: Peter Crosthwaite <peter.crosthwaite@xilinx.com>
> > Signed-off-by: Antony Pavlov <antonynpavlov@gmail.com>
> > CC: Peter Crosthwaite <peter.crosthwaite@xilinx.com>
> > CC: Michael Walle <michael@walle.cc>
> > CC: Andreas F=E4rber <afaerber@suse.de>
> > ---
> >  hw/char/milkymist-uart.c | 24 ++++++++++++++----------
> >  1 file changed, 14 insertions(+), 10 deletions(-)
>=20
> Thanks, applied to qom-next (with shortened commit message):
> https://github.com/afaerber/qemu-cpu/commits/qom-next
>=20

That's about the patch number 1 ( milkymist-uart: use qemu_chr_fe_write_all=
() instead of qemu_chr_fe_write()) ?

--=A0
Best regards,
=A0 Antony Pavlov