From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46764) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VGS26-0008O9-Nr for qemu-devel@nongnu.org; Mon, 02 Sep 2013 07:11:03 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VGS22-0008Qx-DB for qemu-devel@nongnu.org; Mon, 02 Sep 2013 07:10:58 -0400 Received: from hall.aurel32.net ([2001:470:1f0b:4a8::1]:58237) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VGS22-0008Q1-6D for qemu-devel@nongnu.org; Mon, 02 Sep 2013 07:10:54 -0400 Date: Mon, 2 Sep 2013 13:10:39 +0200 From: Aurelien Jarno Message-ID: <20130902111039.GA10492@ohm.aurel32.net> References: <1377810586-19931-1-git-send-email-rth@twiddle.net> <1377810586-19931-2-git-send-email-rth@twiddle.net> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1377810586-19931-2-git-send-email-rth@twiddle.net> Subject: Re: [Qemu-devel] [PATCH v2 01/18] qtest: Fix FMT_timeval vs time_t List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Richard Henderson Cc: qemu-devel@nongnu.org, Andreas =?iso-8859-15?Q?F=E4rber?= On Thu, Aug 29, 2013 at 02:09:29PM -0700, Richard Henderson wrote: > Since FMT_timeval unconditionally uses %ld for both tv_sec and tv_usec, > and already casts tv_usec to long, also cast tv_sec to long. > > Cc: Andreas Färber > Signed-off-by: Richard Henderson > --- > qtest.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/qtest.c b/qtest.c > index ef671fb..584c707 100644 > --- a/qtest.c > +++ b/qtest.c > @@ -177,7 +177,7 @@ static void qtest_send_prefix(CharDriverState *chr) > > qtest_get_time(&tv); > fprintf(qtest_log_fp, "[S +" FMT_timeval "] ", > - tv.tv_sec, (long) tv.tv_usec); > + (long) tv.tv_sec, (long) tv.tv_usec); > } > > static void GCC_FMT_ATTR(2, 3) qtest_send(CharDriverState *chr, > @@ -225,7 +225,7 @@ static void qtest_process_command(CharDriverState *chr, gchar **words) > > qtest_get_time(&tv); > fprintf(qtest_log_fp, "[R +" FMT_timeval "]", > - tv.tv_sec, (long) tv.tv_usec); > + (long) tv.tv_sec, (long) tv.tv_usec); > for (i = 0; words[i]; i++) { > fprintf(qtest_log_fp, " %s", words[i]); > } > @@ -485,7 +485,7 @@ static void qtest_event(void *opaque, int event) > qtest_opened = true; > if (qtest_log_fp) { > fprintf(qtest_log_fp, "[I " FMT_timeval "] OPENED\n", > - start_time.tv_sec, (long) start_time.tv_usec); > + (long) start_time.tv_sec, (long) start_time.tv_usec); > } > break; > case CHR_EVENT_CLOSED: > @@ -494,7 +494,7 @@ static void qtest_event(void *opaque, int event) > qemu_timeval tv; > qtest_get_time(&tv); > fprintf(qtest_log_fp, "[I +" FMT_timeval "] CLOSED\n", > - tv.tv_sec, (long) tv.tv_usec); > + (long) tv.tv_sec, (long) tv.tv_usec); > } > break; > default: Reviewed-by: Aurelien Jarno -- Aurelien Jarno GPG: 1024D/F1BCDB73 aurelien@aurel32.net http://www.aurel32.net