From: "Benoît Canet" <benoit.canet@irqsave.net>
To: Fam Zheng <famz@redhat.com>
Cc: kwolf@redhat.com, stefanha@gmail.com, qemu-devel@nongnu.org,
stefanha@redhat.com, pbonzini@redhat.com
Subject: Re: [Qemu-devel] [PATCH V11 4/5] block: Add support for throttling burst max in QMP and the command line.
Date: Mon, 2 Sep 2013 13:49:07 +0200 [thread overview]
Message-ID: <20130902114907.GD5073@irqsave.net> (raw)
In-Reply-To: <20130902025032.GA9089@T430s.nay.redhat.com>
> > .name = "block_set_io_throttle",
> > - .args_type = "device:B,bps:l,bps_rd:l,bps_wr:l,iops:l,iops_rd:l,iops_wr:l",
> > + .args_type = "device:B,bps:l,bps_rd:l,bps_wr:l,iops:l,iops_rd:l,iops_wr:l,bps_max:l?,bps_rd_max:l?,bps_wr_max:l?,iops_max:l?,iops_rd_max:l?,iops_wr_max:l?",
>
> Too long, wrap this line?
I am afraid it would mess with QMP code generation.
Best regards
Benoît
next prev parent reply other threads:[~2013-09-02 11:47 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-01 16:39 [Qemu-devel] [PATCH V11 0/5] Continuous Leaky Bucket Throttling Benoît Canet
2013-09-01 16:39 ` [Qemu-devel] [PATCH V11 1/5] throttle: Add a new throttling API implementing continuous leaky bucket Benoît Canet
2013-09-02 3:08 ` Fam Zheng
2013-09-02 10:16 ` Benoît Canet
2013-09-02 15:34 ` Paolo Bonzini
2013-09-02 16:06 ` Benoît Canet
2013-09-01 16:39 ` [Qemu-devel] [PATCH V11 2/5] throttle: Add units tests Benoît Canet
2013-09-01 16:39 ` [Qemu-devel] [PATCH V11 3/5] block: Enable the new throttling code in the block layer Benoît Canet
2013-09-02 2:24 ` Fam Zheng
2013-09-02 10:19 ` Benoît Canet
2013-09-01 16:39 ` [Qemu-devel] [PATCH V11 4/5] block: Add support for throttling burst max in QMP and the command line Benoît Canet
2013-09-02 2:50 ` Fam Zheng
2013-09-02 11:49 ` Benoît Canet [this message]
2013-09-01 16:39 ` [Qemu-devel] [PATCH V11 5/5] block: Add iops_size to do the iops accounting for a given io size Benoît Canet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130902114907.GD5073@irqsave.net \
--to=benoit.canet@irqsave.net \
--cc=famz@redhat.com \
--cc=kwolf@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@gmail.com \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).