From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54337) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VGSbB-0005NP-Bb for qemu-devel@nongnu.org; Mon, 02 Sep 2013 07:47:19 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VGSb5-0003A9-90 for qemu-devel@nongnu.org; Mon, 02 Sep 2013 07:47:13 -0400 Received: from nodalink.pck.nerim.net ([62.212.105.220]:58762 helo=paradis.irqsave.net) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VGSb4-0003A1-Vs for qemu-devel@nongnu.org; Mon, 02 Sep 2013 07:47:07 -0400 Date: Mon, 2 Sep 2013 13:49:07 +0200 From: =?iso-8859-1?Q?Beno=EEt?= Canet Message-ID: <20130902114907.GD5073@irqsave.net> References: <1378053587-12121-1-git-send-email-benoit@irqsave.net> <1378053587-12121-5-git-send-email-benoit@irqsave.net> <20130902025032.GA9089@T430s.nay.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline In-Reply-To: <20130902025032.GA9089@T430s.nay.redhat.com> Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH V11 4/5] block: Add support for throttling burst max in QMP and the command line. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Fam Zheng Cc: kwolf@redhat.com, stefanha@gmail.com, qemu-devel@nongnu.org, stefanha@redhat.com, pbonzini@redhat.com > > .name =3D "block_set_io_throttle", > > - .args_type =3D "device:B,bps:l,bps_rd:l,bps_wr:l,iops:l,iop= s_rd:l,iops_wr:l", > > + .args_type =3D "device:B,bps:l,bps_rd:l,bps_wr:l,iops:l,iop= s_rd:l,iops_wr:l,bps_max:l?,bps_rd_max:l?,bps_wr_max:l?,iops_max:l?,iops_= rd_max:l?,iops_wr_max:l?", >=20 > Too long, wrap this line? I am afraid it would mess with QMP code generation. Best regards Beno=EEt