From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55537) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VGShH-0007kU-KM for qemu-devel@nongnu.org; Mon, 02 Sep 2013 07:53:35 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VGShD-0005Xy-7J for qemu-devel@nongnu.org; Mon, 02 Sep 2013 07:53:31 -0400 Date: Mon, 2 Sep 2013 12:53:20 +0100 From: "Richard W.M. Jones" Message-ID: <20130902115320.GA18409@redhat.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Subject: Re: [Qemu-devel] [PATCH] qapi-types.py: Fix enum struct sizes on i686 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Cole Robinson Cc: Michael Roth , Luiz Capitulino , qemu-devel@nongnu.org, qemu-stable@nongnu.org On Sat, Aug 31, 2013 at 06:36:17PM -0400, Cole Robinson wrote: > Unlike other list types, enum wasn't adding any padding, which caused > a mismatch between the generated struct size and GenericList struct > size. More details in a678e26cbe89f7a27cbce794c2c2784571ee9d21 > > This crashed qemu if calling qmp query-tpm-types for example, which > upsets libvirt capabilities probing. Reproducer on i686: > > (sleep 5; printf '{"execute":"qmp_capabilities"}\n{"execute":"query-tpm-types"}\n') | ./i386-softmmu/qemu-system-i386 -S -nodefaults -nographic -M none -qmp stdio > > https://bugs.launchpad.net/qemu/+bug/1219207 > > Cc: qemu-stable@nongnu.org > Signed-off-by: Cole Robinson Works for me, so you can add: Tested-by: Richard W.M. Jones Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Fedora Windows cross-compiler. Compile Windows programs, test, and build Windows installers. Over 100 libraries supported. http://fedoraproject.org/wiki/MinGW