qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Daniel P. Berrange" <berrange@redhat.com>
To: Guannan Ren <gren@redhat.com>
Cc: libvir-list@redhat.com, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [libvirt] [PATCH 3/5] qemu: add usb-bot support from disks points of view
Date: Mon, 2 Sep 2013 13:57:57 +0100	[thread overview]
Message-ID: <20130902125757.GH15704@redhat.com> (raw)
In-Reply-To: <1378114724-1748-4-git-send-email-gren@redhat.com>

On Mon, Sep 02, 2013 at 05:38:42PM +0800, Guannan Ren wrote:
> usb-bot only supports 16 luns(0~15) and they must be contiguous,
> (using lun 0 and 2 without 1 doesn't work). In this case qemu
> doesn't throw an error, we can not find the lun 2 in guests. So
> Adding a checking function in libvirt to prevent from this case.

Hmm, this seems like a problematic restriction.

How does this work if we start off a guest with 3 disks
attached to the usb-bot SCSI controller. Then hot-unplug
the 2nd disk.

Next time we need will need to start with with LUNs 0
and 2 populated only, otherwise we have ABI change upon
migrate or save/restore.

I think this restriction about contiguous luns must be
removed if this device is to be usable with multiple luns.

Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|

       reply	other threads:[~2013-09-02 12:58 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1378114724-1748-1-git-send-email-gren@redhat.com>
     [not found] ` <1378114724-1748-4-git-send-email-gren@redhat.com>
2013-09-02 12:57   ` Daniel P. Berrange [this message]
2013-09-03  3:26     ` [Qemu-devel] [libvirt] [PATCH 3/5] qemu: add usb-bot support from disks points of view Guannan Ren
2013-09-03  7:51     ` Gerd Hoffmann
2013-09-03  9:32       ` Daniel P. Berrange
2013-09-03 12:06         ` Gerd Hoffmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130902125757.GH15704@redhat.com \
    --to=berrange@redhat.com \
    --cc=gren@redhat.com \
    --cc=libvir-list@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).