From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40556) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VGThl-0000T8-Ri for qemu-devel@nongnu.org; Mon, 02 Sep 2013 08:58:09 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VGThi-0001yM-2V for qemu-devel@nongnu.org; Mon, 02 Sep 2013 08:58:05 -0400 Received: from mx1.redhat.com ([209.132.183.28]:8989) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VGThh-0001y8-Qd for qemu-devel@nongnu.org; Mon, 02 Sep 2013 08:58:01 -0400 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r82Cw0UO014416 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Mon, 2 Sep 2013 08:58:00 -0400 Date: Mon, 2 Sep 2013 13:57:57 +0100 From: "Daniel P. Berrange" Message-ID: <20130902125757.GH15704@redhat.com> References: <1378114724-1748-1-git-send-email-gren@redhat.com> <1378114724-1748-4-git-send-email-gren@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <1378114724-1748-4-git-send-email-gren@redhat.com> Subject: Re: [Qemu-devel] [libvirt] [PATCH 3/5] qemu: add usb-bot support from disks points of view Reply-To: "Daniel P. Berrange" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Guannan Ren Cc: libvir-list@redhat.com, qemu-devel@nongnu.org On Mon, Sep 02, 2013 at 05:38:42PM +0800, Guannan Ren wrote: > usb-bot only supports 16 luns(0~15) and they must be contiguous, > (using lun 0 and 2 without 1 doesn't work). In this case qemu > doesn't throw an error, we can not find the lun 2 in guests. So > Adding a checking function in libvirt to prevent from this case. Hmm, this seems like a problematic restriction. How does this work if we start off a guest with 3 disks attached to the usb-bot SCSI controller. Then hot-unplug the 2nd disk. Next time we need will need to start with with LUNs 0 and 2 populated only, otherwise we have ABI change upon migrate or save/restore. I think this restriction about contiguous luns must be removed if this device is to be usable with multiple luns. Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|