From: Stefan Hajnoczi <stefanha@gmail.com>
To: Kevin Wolf <kwolf@redhat.com>
Cc: qemu-devel@nongnu.org, stefanha@redhat.com
Subject: Re: [Qemu-devel] [PATCH] qemu-iotests: Fixed test case 026
Date: Mon, 2 Sep 2013 14:58:23 +0200 [thread overview]
Message-ID: <20130902125823.GA31868@stefanha-thinkpad.redhat.com> (raw)
In-Reply-To: <1378125720-6079-1-git-send-email-kwolf@redhat.com>
On Mon, Sep 02, 2013 at 02:42:00PM +0200, Kevin Wolf wrote:
> diff --git a/tests/qemu-iotests/check b/tests/qemu-iotests/check
> index 74628ae..42d6955 100755
> --- a/tests/qemu-iotests/check
> +++ b/tests/qemu-iotests/check
> @@ -239,12 +239,18 @@ do
> echo -n " [failed, exit status $sts]"
> err=true
> fi
> - if [ ! -f $seq.out ]
> +
> + reference=$seq.out
Please keep the same indentation style as the rest of the file (seems to
use 8-space tabs plus spaces for 4-space indentation).
> + if (echo $QEMU_IO_OPTIONS | grep -s -- '--nocache' > /dev/null); then
man grep says:
"Portable shell scripts should avoid both -q and -s and should redirect
standard and error output to /dev/null instead."
Since you're already redirecting stdout to /dev/null we might as well
redirect stderr too and drop the -s option.
next prev parent reply other threads:[~2013-09-02 12:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-02 12:42 [Qemu-devel] [PATCH] qemu-iotests: Fixed test case 026 Kevin Wolf
2013-09-02 12:58 ` Stefan Hajnoczi [this message]
2013-09-02 13:07 ` Kevin Wolf
2013-09-04 9:55 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130902125823.GA31868@stefanha-thinkpad.redhat.com \
--to=stefanha@gmail.com \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).