From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:40697)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1VGTiF-0001F9-Ja
	for qemu-devel@nongnu.org; Mon, 02 Sep 2013 08:58:43 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1VGTi7-00024O-5W
	for qemu-devel@nongnu.org; Mon, 02 Sep 2013 08:58:35 -0400
Received: from mail-ee0-x22e.google.com ([2a00:1450:4013:c00::22e]:36976)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1VGTi6-00023L-Ux
	for qemu-devel@nongnu.org; Mon, 02 Sep 2013 08:58:27 -0400
Received: by mail-ee0-f46.google.com with SMTP id c13so2330760eek.5
	for <qemu-devel@nongnu.org>; Mon, 02 Sep 2013 05:58:26 -0700 (PDT)
Date: Mon, 2 Sep 2013 14:58:23 +0200
From: Stefan Hajnoczi <stefanha@gmail.com>
Message-ID: <20130902125823.GA31868@stefanha-thinkpad.redhat.com>
References: <1378125720-6079-1-git-send-email-kwolf@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1378125720-6079-1-git-send-email-kwolf@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] qemu-iotests: Fixed test case 026
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Kevin Wolf <kwolf@redhat.com>
Cc: qemu-devel@nongnu.org, stefanha@redhat.com

On Mon, Sep 02, 2013 at 02:42:00PM +0200, Kevin Wolf wrote:
> diff --git a/tests/qemu-iotests/check b/tests/qemu-iotests/check
> index 74628ae..42d6955 100755
> --- a/tests/qemu-iotests/check
> +++ b/tests/qemu-iotests/check
> @@ -239,12 +239,18 @@ do
>  		echo -n " [failed, exit status $sts]"
>  		err=true
>  	    fi
> -	    if [ ! -f $seq.out ]
> +
> +        reference=$seq.out

Please keep the same indentation style as the rest of the file (seems to
use 8-space tabs plus spaces for 4-space indentation).

> +        if (echo $QEMU_IO_OPTIONS | grep -s -- '--nocache' > /dev/null); then

man grep says:
"Portable shell scripts should avoid both -q and -s and should redirect
standard and error output to /dev/null instead."

Since you're already redirecting stdout to /dev/null we might as well
redirect stderr too and drop the -s option.