From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:42580)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1VGTr6-000725-90
	for qemu-devel@nongnu.org; Mon, 02 Sep 2013 09:07:50 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1VGTr0-0004qI-8v
	for qemu-devel@nongnu.org; Mon, 02 Sep 2013 09:07:44 -0400
Received: from mx1.redhat.com ([209.132.183.28]:51583)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1VGTr0-0004qE-0s
	for qemu-devel@nongnu.org; Mon, 02 Sep 2013 09:07:38 -0400
Date: Mon, 2 Sep 2013 15:07:39 +0200
From: Kevin Wolf <kwolf@redhat.com>
Message-ID: <20130902130739.GC3423@dhcp-200-207.str.redhat.com>
References: <1378125720-6079-1-git-send-email-kwolf@redhat.com>
	<20130902125823.GA31868@stefanha-thinkpad.redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20130902125823.GA31868@stefanha-thinkpad.redhat.com>
Subject: Re: [Qemu-devel] [PATCH] qemu-iotests: Fixed test case 026
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefan Hajnoczi <stefanha@gmail.com>
Cc: qemu-devel@nongnu.org, stefanha@redhat.com

Am 02.09.2013 um 14:58 hat Stefan Hajnoczi geschrieben:
> On Mon, Sep 02, 2013 at 02:42:00PM +0200, Kevin Wolf wrote:
> > diff --git a/tests/qemu-iotests/check b/tests/qemu-iotests/check
> > index 74628ae..42d6955 100755
> > --- a/tests/qemu-iotests/check
> > +++ b/tests/qemu-iotests/check
> > @@ -239,12 +239,18 @@ do
> >  		echo -n " [failed, exit status $sts]"
> >  		err=true
> >  	    fi
> > -	    if [ ! -f $seq.out ]
> > +
> > +        reference=$seq.out
> 
> Please keep the same indentation style as the rest of the file (seems to
> use 8-space tabs plus spaces for 4-space indentation).

I could live with just tabs, but this kind of mix is a totally broken
style. :-/

I'd rather send a patch to convert the whole qemu-iotests scripts to
spaces first. Would you agree with that?

> > +        if (echo $QEMU_IO_OPTIONS | grep -s -- '--nocache' > /dev/null); then
> 
> man grep says:
> "Portable shell scripts should avoid both -q and -s and should redirect
> standard and error output to /dev/null instead."
> 
> Since you're already redirecting stdout to /dev/null we might as well
> redirect stderr too and drop the -s option.

Okay, will do in v2, though I generally don't care about portability of
qemu-iotests.

Kevin