From: Kevin Wolf <kwolf@redhat.com>
To: Max Reitz <mreitz@redhat.com>
Cc: qemu-devel@nongnu.org, Stefan Hajnoczi <stefanha@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v4 5/5] qemu-iotest: qcow2 image option amendment
Date: Mon, 2 Sep 2013 17:36:20 +0200 [thread overview]
Message-ID: <20130902153620.GE3423@dhcp-200-207.str.redhat.com> (raw)
In-Reply-To: <1378116246-12855-6-git-send-email-mreitz@redhat.com>
Am 02.09.2013 um 12:04 hat Max Reitz geschrieben:
> Add tests for qemu-img amend on qcow2 image files.
>
> Signed-off-by: Max Reitz <mreitz@redhat.com>
> ---
> tests/qemu-iotests/061 | 178 +++++++++++++++++++++++
> tests/qemu-iotests/061.out | 349 +++++++++++++++++++++++++++++++++++++++++++++
> tests/qemu-iotests/group | 1 +
> 3 files changed, 528 insertions(+)
> create mode 100755 tests/qemu-iotests/061
> create mode 100644 tests/qemu-iotests/061.out
> +echo
> +echo "=== Testing version upgrade and resize ==="
> +echo
> +IMGOPTS="compat=0.10" _make_test_img 64M
> +$QEMU_IO -c "write -P 0x2a 42M 64k" "$TEST_IMG" | _filter_qemu_io
> +./qcow2.py "$TEST_IMG" dump-header
> +$QEMU_IMG amend -o "compat=1.1,lazy_refcounts=on,size=128M" "$TEST_IMG"
> +./qcow2.py "$TEST_IMG" dump-header
> +$QEMU_IO -c "read -P 0x2a 42M 64k" "$TEST_IMG" | _filter_qemu_io
> +_check_test_img
Your reference output isn't correct for this test: It expects a 64 MB
image after the amend. Looks like there's a bug somewhere.
Kevin
next prev parent reply other threads:[~2013-09-02 15:36 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-02 10:04 [Qemu-devel] [PATCH v4 0/5] block/qcow2: Image file option amendment Max Reitz
2013-09-02 10:04 ` [Qemu-devel] [PATCH v4 1/5] block: " Max Reitz
2013-09-02 10:04 ` [Qemu-devel] [PATCH v4 2/5] qcow2-cluster: Expand zero clusters Max Reitz
2013-09-02 15:13 ` Kevin Wolf
2013-09-03 7:11 ` Max Reitz
2013-09-02 10:04 ` [Qemu-devel] [PATCH v4 3/5] qcow2: Save refcount order in BDRVQcowState Max Reitz
2013-09-02 10:04 ` [Qemu-devel] [PATCH v4 4/5] qcow2: Implement bdrv_amend_options Max Reitz
2013-09-02 10:04 ` [Qemu-devel] [PATCH v4 5/5] qemu-iotest: qcow2 image option amendment Max Reitz
2013-09-02 15:36 ` Kevin Wolf [this message]
2013-09-03 7:12 ` Max Reitz
2013-09-03 8:23 ` Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130902153620.GE3423@dhcp-200-207.str.redhat.com \
--to=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).